Review main Merged

75616[TASK] Avoid PHP8.2 related deprecation failure in unit test

Stefan Bürk CR +2 V +2 Normal +41 −15 updated 09/06/22, 18:34

Commit message

With PHP8.2 setting dynamic properties has been deprecated. This
is also valid if it is set through unserialization and emits a
deprecation warning. Thus this fails hard in tests.

Thus one test fails, which is expclicitly testing unserialization
with invalid dynamic class properties.

This change moves the test to unitDeprecated tests, which will not
fail on deprecation warnings. This acts pre-patch to update PHP8.2
testing to `PHP8.2.0 RC1`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Stefan Bürk uploaded patch set 1 09/06/22, 16:15

  2. core-ci voted on patch set 1 V +1 09/06/22, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30654

  3. Stefan Bürk updated the commit message in patch set 2 09/06/22, 16:28

  4. core-ci voted on patch set 2 V +1 09/06/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30656

  5. Oliver Klee voted on patch set 2 V +1 CR +1 09/06/22, 17:17

  6. Georg Ringer voted on patch set 2 V +2 CR +2 09/06/22, 18:34

  7. Georg Ringer merged patch set 3 09/06/22, 18:34