Review main Merged

75619[DOCS] Clarify the page TSconfig settings for RTE

Lina Wolf CR +2 V +2 Easy +23 −27 updated 09/07/22, 04:35

Commit message

Link to the TSconfig reference where it makes sense,
also for setting page TSConfic, as this changed in v12.
We do not need to duplicate the information here.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Lina Wolf uploaded patch set 1 09/06/22, 17:35

  2. core-ci voted on patch set 1 V +1 09/06/22, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30663

  3. Lina Wolf uploaded patch set 2 09/06/22, 18:14

  4. Mathias Bolt Lesniak commented on patch set 2 09/06/22, 18:19

    Link to the TSconfig reference where it makes sense, also for setting page TSConfic, as this changed in v12. We do not need to duplicate the information here.

    ConfigureTypo3.rst:28

    We recommend you to put all configurations for the preset in the :ref:`YAML <config-typo3-yaml>` configuration. However, it is still possible to override these settings through the page TSconfig. You can find a list of configuration properties in the :ref:`Page TSconfig reference, chapter RTE <t3tsconfig:pageTsRte>`.

    Reference.rst:140

    We recommend you to put all configurations for the preset in the :ref:`YAML <config-typo3-yaml>` configuration. However, it is still possible to override these settings through the page TSconfig. You can find a list of configuration properties in the :ref:`Page TSconfig reference, chapter RTE <t3tsconfig:pageTsRte>`.
  5. core-ci voted on patch set 2 V +1 09/06/22, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30666

  6. Lina Wolf updated the commit message in patch set 3 09/06/22, 19:52

  7. Lina Wolf uploaded patch set 4 09/06/22, 19:55

  8. Lina Wolf commented on patch set 4 09/06/22, 19:56

    Reply

    Done

    ConfigureTypo3.rst:28 Reply

    Done

    Reference.rst:140 Reply

    Done
  9. core-ci voted on patch set 3 V +1 09/06/22, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30679

  10. core-ci voted on patch set 4 V +1 09/06/22, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30682

  11. Benni Mack voted on patch set 4 V +1 CR +1 09/06/22, 20:39

  12. Georg Ringer voted on patch set 4 V +2 CR +2 09/07/22, 04:35

  13. Georg Ringer merged patch set 5 09/07/22, 04:35