Review main Merged

75620[TASK] Deprecate TYPO3_mainDir

Benni Mack CR +2 V +2 Hard +225 −135 updated 09/07/22, 16:08

Commit message

This patch deprecates the constant "TYPO3_mainDir"
in favor of a BackendEntryPointResolver which
contains the information in a unified way to work with
the prefix for the path or URL.

Some tests are adapted properly to run in "frontend
context" now (e.g. felogin") to simulate the proper
behavior.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 2540

Show 815 earlier messages
  1. Benni Mack uploaded patch set 1 09/06/22, 18:26

  2. core-ci voted on patch set 1 V -1 09/06/22, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30667

  3. Benni Mack uploaded patch set 2 09/06/22, 19:22

  4. core-ci voted on patch set 2 V -1 09/06/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30676

  5. Benni Mack uploaded patch set 3 09/06/22, 19:47

  6. core-ci voted on patch set 3 V -1 09/06/22, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30677

  7. Benni Mack uploaded patch set 4 09/06/22, 21:03

  8. core-ci voted on patch set 4 V -1 09/06/22, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30690

  9. Benni Mack uploaded patch set 5 09/07/22, 10:44

  10. core-ci voted on patch set 5 V -1 09/07/22, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30733

  11. Benni Mack uploaded patch set 6 09/07/22, 11:16

  12. core-ci voted on patch set 6 V +1 09/07/22, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30741

  13. Benni Mack uploaded patch set 7 09/07/22, 12:18

  14. core-ci voted on patch set 7 V -1 09/07/22, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30748

  15. Benni Mack uploaded patch set 8 09/07/22, 13:18

  1. Benni Mack uploaded patch set 9 09/07/22, 13:25

  2. core-ci voted on patch set 8 V -1 09/07/22, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30752

  3. core-ci voted on patch set 9 V -1 09/07/22, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30753

  4. Benni Mack uploaded patch set 10 09/07/22, 13:51

  5. core-ci voted on patch set 10 V +1 09/07/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30754

  6. Benni Mack commented on patch set 10 CR -2 09/07/22, 14:03

    will add DI to it.
  7. Benni Mack uploaded patch set 11 09/07/22, 14:19

  8. Benni Mack voted on patch set 10 CR 0 09/07/22, 14:20

  9. core-ci voted on patch set 11 V -1 09/07/22, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30755

  10. Benni Mack uploaded patch set 12 09/07/22, 14:43

  11. core-ci voted on patch set 12 V +1 09/07/22, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30758

  12. Benni Mack commented on patch set 13 09/07/22, 15:15

    Published edit on patch set 12.
  13. Benjamin Franzke voted on patch set 13 CR +1 09/07/22, 15:16

  14. core-ci voted on patch set 13 V +1 09/07/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30763

  15. Susi Moog voted on patch set 13 CR +1 09/07/22, 15:25

  16. Benjamin Franzke voted on patch set 13 V +1 09/07/22, 15:30

  17. Susi Moog commented on patch set 13 V -1 09/07/22, 15:33

    breaks admin panel "open page in backend"
  18. Benni Mack uploaded patch set 14 09/07/22, 15:35

  19. Benni Mack commented on patch set 13 CR -1 09/07/22, 15:37

    on it
  20. Benni Mack uploaded patch set 15 09/07/22, 15:38

  21. core-ci voted on patch set 14 V +1 09/07/22, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30765

  22. Susi Moog voted on patch set 15 V +1 CR +1 09/07/22, 15:50

  23. core-ci voted on patch set 15 V +1 09/07/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30767

  24. Benjamin Franzke voted on patch set 15 V +2 CR +2 09/07/22, 16:07

  25. Benjamin Franzke merged patch set 16 09/07/22, 16:08