Review main Merged

75622[TASK] Localize text in modal JavaScript

Sybille Peters CR +2 V +2 Easy +6 −3 updated 12/19/22, 11:54

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1421

  1. Sybille Peters uploaded patch set 1 09/06/22, 19:03

  2. core-ci voted on patch set 1 V +1 09/06/22, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30672

  3. Sybille Peters updated the commit message in patch set 2 09/06/22, 19:14

  4. core-ci voted on patch set 2 V +1 09/06/22, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30674

  5. Oli Bartsch commented on patch set 2 09/06/22, 19:26

    locallang_mod_web_list.xlf:174

    Not quite sure if this is the correct place for the new label, since it's actually not dedicated to the web_list module, which this locallang is used for. Maybe we can find another place, e.g. "locallang_core.xlf". What do you think?
  6. Sybille Peters uploaded patch set 3 09/07/22, 06:14

  7. Sybille Peters commented on patch set 3 09/07/22, 06:16

    locallang_mod_web_list.xlf:174 Reply

    Sounds good :) Is fixed.
  8. Sybille Peters uploaded patch set 4 09/07/22, 06:18

  9. core-ci voted on patch set 3 V +1 09/07/22, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30697

  10. core-ci voted on patch set 4 V +1 09/07/22, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30698

  11. Sybille Peters uploaded patch set 5 V +1 12/01/22, 11:34

  12. Sybille Peters updated the commit message in patch set 6 12/01/22, 11:36

  13. core-ci voted on patch set 5 V +1 12/01/22, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34475

  14. core-ci voted on patch set 6 V +1 12/01/22, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34477

  15. Guido Schmechel commented on patch set 6 CR -1 12/15/22, 23:32

    locallang_core.xlf:1465

    One r too much :-)
  16. Frank Nägler commented on patch set 7 CR -1 V +1 12/16/22, 12:56

    Published edit on patch set 6.
  17. Frank Nägler commented on patch set 7 12/16/22, 12:57

    locallang_core.xlf:1465 Reply

    Ack
  18. Frank Nägler voted on patch set 7 V +1 CR +1 12/16/22, 12:57

  19. core-ci voted on patch set 7 V +1 12/16/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35197

  20. Benni Mack voted on patch set 7 V +2 CR +2 12/19/22, 11:54

  21. Benni Mack merged patch set 8 12/19/22, 11:54