Review main Merged

75624[TASK] Drop usage of sass:math

Benjamin Kott CR +2 V +2 Normal +40 −126 updated 09/07/22, 15:28

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 78

  1. Benjamin Kott uploaded patch set 1 09/06/22, 20:12

  2. Benni Mack voted on patch set 1 CR +1 09/06/22, 20:15

  3. core-ci voted on patch set 1 V +1 09/06/22, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30685

  4. Benni Mack voted on patch set 1 V +1 09/06/22, 20:30

  5. Georg Ringer voted on patch set 1 V +2 CR +2 09/06/22, 20:41

  6. Georg Ringer merged patch set 2 09/06/22, 20:41

  7. Oli Bartsch commented on patch set 2 09/06/22, 20:44

    Unresolved

    Post -1. Some components seem to behave wrong now. E.g. the dropdown in recordlist has wrong paddings.
  8. Benjamin Franzke commented on patch set 2 09/07/22, 15:28

    Unresolved

    Would have loved background info regarding the reasoning.