Review main Merged Breaking

75626[!!!][FEATURE] Add generic language overlay PSR-14 events instead of hooks

Benni Mack CR +2 V +2 Hard +472 −86 updated 09/09/22, 09:51

Commit message

New PSR-14 events are introduced in favor of old hooks
within PageRepository which are related to overlaying
records. This is now achieved by using
PageRepository->getLanguageOverlay() consistently
which now contains the events both for pages and any other
kind of translatable record.

The main benefit of the events are that they consistently
work with LanguageAspect instead of integers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 2642

Show 917 earlier messages
  1. Benni Mack uploaded patch set 1 09/06/22, 20:30

  2. core-ci voted on patch set 1 V -1 09/06/22, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30688

  3. Benni Mack uploaded patch set 2 09/06/22, 20:42

  4. core-ci voted on patch set 2 V -1 09/06/22, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30689

  5. Benni Mack commented on patch set 3 09/06/22, 21:10

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 09/06/22, 22:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30691

  7. Benni Mack uploaded patch set 4 09/08/22, 13:57

  8. core-ci voted on patch set 4 V -1 09/08/22, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30823

  9. Benni Mack uploaded patch set 5 09/08/22, 16:09

  10. core-ci voted on patch set 5 V -1 09/08/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30844

  11. Benni Mack uploaded patch set 6 09/08/22, 16:31

  12. core-ci voted on patch set 6 V +1 09/08/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30846

  13. Benni Mack uploaded patch set 7 09/08/22, 17:54

  14. core-ci voted on patch set 7 V +1 09/08/22, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30858

  15. Benni Mack uploaded patch set 8 09/08/22, 19:21

  16. core-ci voted on patch set 8 V -1 09/08/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30860

  17. Benni Mack uploaded patch set 9 09/08/22, 19:39

  1. core-ci voted on patch set 9 V +1 09/08/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30861

  2. Oli Bartsch commented on patch set 9 CR -1 09/08/22, 20:00

    On it
  3. Susi Moog commented on patch set 9 CR -1 09/08/22, 20:03

    AfterRecordLanguageOverlayEvent.php:48

    weird setter.

    AfterRecordLanguageOverlayEvent.php:55

    should setting bool be allowed or is setting bool internal/ideally deprecated?

    Feature-98303-PSR-14EventsForModifyingLanguageOverlays.rst:14

    what?
  4. Oli Bartsch uploaded patch set 10 09/08/22, 20:40

  5. Oli Bartsch commented on patch set 10 CR +1 09/08/22, 20:42

    AfterRecordLanguageOverlayEvent.php:48 Reply

    Done

    AfterRecordLanguageOverlayEvent.php:55 Reply

    Bool is internal to detect whether an overlay was done at all. See last line in PageRepositors->getLanguageOverlay()

    Feature-98303-PSR-14EventsForModifyingLanguageOverlays.rst:14 Reply

    Done
  6. core-ci voted on patch set 10 V -1 09/08/22, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30865

  7. Benni Mack uploaded patch set 11 09/09/22, 06:57

  8. Benni Mack updated the commit message in patch set 12 09/09/22, 06:57

  9. core-ci voted on patch set 11 V -1 09/09/22, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30876

  10. core-ci voted on patch set 12 V -1 09/09/22, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30877

  11. Oli Bartsch uploaded patch set 13 09/09/22, 07:41

  12. core-ci voted on patch set 13 V +1 09/09/22, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30882

  13. Oli Bartsch voted on patch set 13 V +1 CR +1 09/09/22, 07:56

  14. Susi Moog commented on patch set 13 CR -1 09/09/22, 09:09

    PageRepository.php:413

    getRecord here has no setter to manipulate it in the event, therefore I'd say we don't need to call the getter here, to avoid the impression that the event should be able to change anything (OR: we should add the setter again, because it may make sense to manipulate the original record if no localizedRecord exists).
  15. Benni Mack uploaded patch set 14 09/09/22, 09:31

  16. Benni Mack commented on patch set 14 09/09/22, 09:31

    PageRepository.php:413 Reply

    Done
  17. Benni Mack uploaded patch set 15 09/09/22, 09:34

  18. Benni Mack uploaded patch set 16 09/09/22, 09:39

  19. Oli Bartsch voted on patch set 16 V +1 CR +1 09/09/22, 09:42

  20. core-ci voted on patch set 14 V +1 09/09/22, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30899

  21. core-ci voted on patch set 16 V +1 09/09/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30902

  22. Susi Moog voted on patch set 16 V +1 CR +1 09/09/22, 09:49

  23. Benni Mack voted on patch set 16 V +2 CR +2 09/09/22, 09:49

  24. Benni Mack merged patch set 17 09/09/22, 09:49

  25. core-ci voted on patch set 15 V +1 09/09/22, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30901