75626[!!!][FEATURE] Add generic language overlay PSR-14 events instead of hooks
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Classes/Domain/Event/AfterRecordLanguageOverlayEvent.php4new+69 −0
- typo3/sysext/core/Classes/Domain/Event/BeforePageLanguageOverlayEvent.phpnew+64 −0
- typo3/sysext/core/Classes/Domain/Event/BeforeRecordLanguageOverlayEvent.phpnew+59 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php2+83 −77
- typo3/sysext/core/Classes/Domain/Repository/PageRepositoryGetPageOverlayHookInterface.php+2 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepositoryGetRecordOverlayHookInterface.php+2 −0
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+2 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98303-RemovedHooksForLanguageOverlaysInPageRepository.rstnew+59 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-98303-InterfacesForPageRepositoryLanguageOverlayHooks.rstnew+50 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98303-PSR-14EventsForModifyingLanguageOverlays.rst2new+46 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+14 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+14 −0
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+5 −3
Review log 2642
Show 917 earlier messages
-
Benni Mack uploaded patch set 1 09/06/22, 20:30
-
core-ci voted on patch set 1 V -1 09/06/22, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30688
-
Benni Mack uploaded patch set 2 09/06/22, 20:42
-
core-ci voted on patch set 2 V -1 09/06/22, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30689
-
Benni Mack commented on patch set 3 09/06/22, 21:10
Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 09/06/22, 22:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30691
-
Benni Mack uploaded patch set 4 09/08/22, 13:57
-
core-ci voted on patch set 4 V -1 09/08/22, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30823
-
Benni Mack uploaded patch set 5 09/08/22, 16:09
-
core-ci voted on patch set 5 V -1 09/08/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30844
-
Benni Mack uploaded patch set 6 09/08/22, 16:31
-
core-ci voted on patch set 6 V +1 09/08/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30846
-
Benni Mack uploaded patch set 7 09/08/22, 17:54
-
core-ci voted on patch set 7 V +1 09/08/22, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30858
-
Benni Mack uploaded patch set 8 09/08/22, 19:21
-
core-ci voted on patch set 8 V -1 09/08/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30860
-
Benni Mack uploaded patch set 9 09/08/22, 19:39
-
core-ci voted on patch set 9 V +1 09/08/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30861
-
Oli Bartsch commented on patch set 9 CR -1 09/08/22, 20:00
On it -
Susi Moog commented on patch set 9 CR -1 09/08/22, 20:03
AfterRecordLanguageOverlayEvent.php:48weird setter.AfterRecordLanguageOverlayEvent.php:55should setting bool be allowed or is setting bool internal/ideally deprecated?Feature-98303-PSR-14EventsForModifyingLanguageOverlays.rst:14what? -
Oli Bartsch uploaded patch set 10 09/08/22, 20:40
-
Oli Bartsch commented on patch set 10 CR +1 09/08/22, 20:42
AfterRecordLanguageOverlayEvent.php:48ReplyDoneAfterRecordLanguageOverlayEvent.php:55ReplyBool is internal to detect whether an overlay was done at all. See last line in PageRepositors->getLanguageOverlay()Feature-98303-PSR-14EventsForModifyingLanguageOverlays.rst:14ReplyDone -
core-ci voted on patch set 10 V -1 09/08/22, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30865
-
Benni Mack uploaded patch set 11 09/09/22, 06:57
-
Benni Mack updated the commit message in patch set 12 09/09/22, 06:57
-
core-ci voted on patch set 11 V -1 09/09/22, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30876
-
core-ci voted on patch set 12 V -1 09/09/22, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30877
-
Oli Bartsch uploaded patch set 13 09/09/22, 07:41
-
core-ci voted on patch set 13 V +1 09/09/22, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30882
-
Oli Bartsch voted on patch set 13 V +1 CR +1 09/09/22, 07:56
-
Susi Moog commented on patch set 13 CR -1 09/09/22, 09:09
PageRepository.php:413getRecord here has no setter to manipulate it in the event, therefore I'd say we don't need to call the getter here, to avoid the impression that the event should be able to change anything (OR: we should add the setter again, because it may make sense to manipulate the original record if no localizedRecord exists). -
Benni Mack uploaded patch set 14 09/09/22, 09:31
-
Benni Mack commented on patch set 14 09/09/22, 09:31
PageRepository.php:413ReplyDone -
Benni Mack uploaded patch set 15 09/09/22, 09:34
-
Benni Mack uploaded patch set 16 09/09/22, 09:39
-
Oli Bartsch voted on patch set 16 V +1 CR +1 09/09/22, 09:42
-
core-ci voted on patch set 14 V +1 09/09/22, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30899
-
core-ci voted on patch set 16 V +1 09/09/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30902
-
Susi Moog voted on patch set 16 V +1 CR +1 09/09/22, 09:49
-
Benni Mack voted on patch set 16 V +2 CR +2 09/09/22, 09:49
-
Benni Mack merged patch set 17 09/09/22, 09:49
-
core-ci voted on patch set 15 V +1 09/09/22, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30901