Review main Merged Breaking

75629[!!!][TASK] Remove possibility to pre-define link titles in link browser

Andreas Kienast CR +2 V +2 Normal +58 −44 updated 09/07/22, 09:27

Commit message

Back in the old HTMLArea it was possible to pre-define a link title in
the `classesAnchor` configuration which got applied after selecting the
CSS class for a link. This feature was migrated to EXT:rte_ckeditor in
TYPO3 v8.

From an SEO and accessibility point of view, this doesn't make much sense
as this would lead to repetitive usage of the same link title, not
helping much at all.

For those reasons, the possibilities to

* pre-define a link title
* make the link title field readonly

have been removed without substitution.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Andreas Kienast uploaded patch set 1 09/07/22, 09:01

  2. Andreas Kienast uploaded patch set 2 09/07/22, 09:03

  3. Benni Mack voted on patch set 2 CR +1 09/07/22, 09:07

  4. core-ci voted on patch set 1 V +1 09/07/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30710

  5. Susi Moog voted on patch set 2 V +1 CR +1 09/07/22, 09:12

  6. core-ci voted on patch set 2 V +1 09/07/22, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30711

  7. Benni Mack voted on patch set 2 V +1 09/07/22, 09:16

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 09/07/22, 09:26

  9. Andreas Kienast merged patch set 3 09/07/22, 09:27