75655[!!!][TASK] Make the AbstractPlugin @internal
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Andreas Kienast +1
- Thomas Löffler +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1720
-
Lina Wolf uploaded patch set 1 09/07/22, 11:58
-
core-ci voted on patch set 1 V +1 09/07/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30747
-
Andreas Kienast commented on patch set 1 CR -1 09/07/22, 12:15
on it -
Andreas Kienast uploaded patch set 2 09/07/22, 12:22
-
core-ci voted on patch set 2 V +1 09/07/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30749
-
Benni Mack commented on patch set 2 09/07/22, 15:02
Breaking-98281-MakeAbstractPluginInternal.rst:114can we also have a snippet on how to use this with TypoScript. tt_content.myCType = USER tt_content.myCType.userFunc = blabla...RandomContent->main -
Lina Wolf commented on patch set 2 09/08/22, 07:04
Breaking-98281-MakeAbstractPluginInternal.rst:114ReplyThere is actually no change to the TypoScript Snippet needed. Shall we still mention it here? Before and after it is ``` plugin.tx_ghrandomcontent_pi1 = USER_INT plugin.tx_ghrandomcontent_pi1 { userFunc = Amazing\GhRandomcontent\Plugin\RandomContent->main // some settings } ``` -
Lina Wolf commented on patch set 2 09/08/22, 18:58
Breaking-98281-MakeAbstractPluginInternal.rst:114ReplyDone -
Andreas Kienast voted on patch set 2 V +1 CR +1 09/09/22, 09:29
-
Benni Mack voted on patch set 2 V +1 CR +1 09/09/22, 09:39
-
Benni Mack commented on patch set 2 V 0 CR -1 09/09/22, 09:45
we could / should add a ExtensionScanner file for the PHP class -
Lina Wolf uploaded patch set 3 09/09/22, 12:16
-
Lina Wolf commented on patch set 3 09/09/22, 12:17
Reply
I added it to the matcher -
core-ci voted on patch set 3 V +1 09/09/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30926
-
Andreas Kienast voted on patch set 3 V +1 CR +1 09/09/22, 13:09
-
Oliver Klee voted on patch set 3 CR +1 09/09/22, 13:28
-
Thomas Löffler voted on patch set 3 CR +1 09/12/22, 15:03
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/16/22, 11:54
-
Stefan Bürk voted on patch set 3 V +2 CR +2 09/16/22, 11:54
-
Stefan Bürk merged patch set 4 09/16/22, 11:54