Review main Merged Breaking

75655[!!!][TASK] Make the AbstractPlugin @internal

Lina Wolf CR +2 V +2 Normal +124 −0 updated 09/16/22, 11:54

Commit message

`\TYPO3\CMS\Frontend\Plugin\AbstractPlugin` is not a recommended way of
developing Frontend Plugins anymore. As long as it is neither deprecated
nor internal we cannot remove it from the documentation.
Also, it is one of the features that let TYPO3 appear outdated.

There are still several non-Extbase plugins that base on
`AbstractPlugin`. However, in most cases, the same result can be achieved
by removing `AbstractPlugin` as parent class.

In the rare case where functionality of `AbstractPlugin` is still used,
those methods can be copied into the affected plugin.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Thomas Löffler +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1720

  1. Lina Wolf uploaded patch set 1 09/07/22, 11:58

  2. core-ci voted on patch set 1 V +1 09/07/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30747

  3. Andreas Kienast commented on patch set 1 CR -1 09/07/22, 12:15

    on it
  4. Andreas Kienast uploaded patch set 2 09/07/22, 12:22

  5. core-ci voted on patch set 2 V +1 09/07/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30749

  6. Benni Mack commented on patch set 2 09/07/22, 15:02

    Breaking-98281-MakeAbstractPluginInternal.rst:114

    can we also have a snippet on how to use this with TypoScript. tt_content.myCType = USER tt_content.myCType.userFunc = blabla...RandomContent->main
  7. Lina Wolf commented on patch set 2 09/08/22, 07:04

    Breaking-98281-MakeAbstractPluginInternal.rst:114 Reply

    There is actually no change to the TypoScript Snippet needed. Shall we still mention it here? Before and after it is ``` plugin.tx_ghrandomcontent_pi1 = USER_INT plugin.tx_ghrandomcontent_pi1 { userFunc = Amazing\GhRandomcontent\Plugin\RandomContent->main // some settings } ```
  8. Lina Wolf commented on patch set 2 09/08/22, 18:58

    Breaking-98281-MakeAbstractPluginInternal.rst:114 Reply

    Done
  9. Andreas Kienast voted on patch set 2 V +1 CR +1 09/09/22, 09:29

  10. Benni Mack voted on patch set 2 V +1 CR +1 09/09/22, 09:39

  11. Benni Mack commented on patch set 2 V 0 CR -1 09/09/22, 09:45

    we could / should add a ExtensionScanner file for the PHP class
  12. Lina Wolf uploaded patch set 3 09/09/22, 12:16

  13. Lina Wolf commented on patch set 3 09/09/22, 12:17

    Reply

    I added it to the matcher
  14. core-ci voted on patch set 3 V +1 09/09/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30926

  15. Andreas Kienast voted on patch set 3 V +1 CR +1 09/09/22, 13:09

  16. Oliver Klee voted on patch set 3 CR +1 09/09/22, 13:28

  17. Thomas Löffler voted on patch set 3 CR +1 09/12/22, 15:03

  18. Christian Kuhn voted on patch set 3 V +1 CR +1 09/16/22, 11:54

  19. Stefan Bürk voted on patch set 3 V +2 CR +2 09/16/22, 11:54

  20. Stefan Bürk merged patch set 4 09/16/22, 11:54