Review main Merged

75656[TASK] Streamline datepicker component styling

Benjamin Kott CR +2 V +2 Hard +327 −444 updated 09/07/22, 18:39

Commit message

The datetimepicker (flatpickr) is now not based on
the Bootstrap DateTimePicker (which was used before),
but uses native CSS variables and SCSS features
to be styled properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Benjamin Kott uploaded patch set 1 09/07/22, 16:29

  2. core-ci voted on patch set 1 V -1 09/07/22, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30769

  3. Benjamin Kott uploaded patch set 2 09/07/22, 16:39

  4. core-ci voted on patch set 2 V +1 09/07/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30770

  5. Benni Mack voted on patch set 2 V +1 CR +1 09/07/22, 16:54

  6. Benni Mack updated the commit message in patch set 3 09/07/22, 16:55

  7. Benni Mack voted on patch set 3 V +1 CR +1 09/07/22, 16:55

  8. core-ci voted on patch set 3 V +1 09/07/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30772

  9. Jonas Eberle voted on patch set 3 V +1 CR +1 09/07/22, 17:15

  10. Lina Wolf commented on patch set 3 V +1 CR +1 09/07/22, 18:29

    The Datapicker works fine for me and looks good. Reviewed the scss and it looks good
  11. Benni Mack voted on patch set 3 V +2 CR +2 09/07/22, 18:39

  12. Benni Mack merged patch set 4 09/07/22, 18:39