Review main Merged

75658[TASK] Cleanup Components

Benjamin Kott CR +2 V +2 Expert +1077 −938 updated 09/09/22, 09:14

Commit message

This patch cleans up and streamlines the dropdown,
datepicker and context menu css components.

They now look unified, by day and night.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 64

Show 44 more files

Review log 3143

Show 1118 earlier messages
  1. Benjamin Kott uploaded patch set 1 09/07/22, 20:54

  2. core-ci voted on patch set 1 V +1 09/07/22, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30785

  3. Benjamin Kott uploaded patch set 2 09/08/22, 17:07

  4. Benni Mack uploaded patch set 3 09/08/22, 17:11

  5. core-ci voted on patch set 2 V -1 09/08/22, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30849

  6. core-ci voted on patch set 3 V -1 09/08/22, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30851

  7. Benjamin Kott uploaded patch set 4 09/08/22, 19:49

  8. core-ci voted on patch set 4 V -1 09/08/22, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30862

  9. Benjamin Kott uploaded patch set 5 09/08/22, 20:41

  10. Benjamin Kott marked it ready for review 09/08/22, 20:42

  11. Benjamin Kott updated the commit message in patch set 6 09/08/22, 20:44

  12. Benjamin Kott marked it ready for review 09/08/22, 20:45

  13. core-ci voted on patch set 5 V -1 09/08/22, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30866

  14. core-ci voted on patch set 6 V -1 09/08/22, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30867

  15. Andreas Kienast commented on patch set 6 CR -1 09/09/22, 06:38

    on it
  16. Andreas Kienast uploaded patch set 7 09/09/22, 07:03

  17. Andreas Kienast commented on patch set 7 V -1 09/09/22, 07:04

    The livesearch is bugged. When searching something, I'm able to close the result list by clicking into the search field only. Due to this, I can never open the result list again as it gets closed immediately again.
  18. core-ci voted on patch set 7 V +1 09/09/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30878

  1. Andreas Kienast uploaded patch set 8 09/09/22, 07:24

  2. Andreas Kienast commented on patch set 8 V -1 09/09/22, 07:28

    Keyboard navigation in search is broken
  3. core-ci voted on patch set 8 V +1 09/09/22, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30879

  4. Benjamin Kott uploaded patch set 9 09/09/22, 07:39

  5. Benjamin Kott uploaded patch set 10 09/09/22, 07:46

  6. core-ci voted on patch set 9 V +1 09/09/22, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30881

  7. Andreas Kienast commented on patch set 10 V +1 CR +1 09/09/22, 07:53

    Keyboard navigation is semi-broken, the items are not visually marked. We decided to drop the current autocomplete library altogether and replace it with a custom component, since auto-suggesting is no witchcraft.
  8. core-ci voted on patch set 10 V +1 09/09/22, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30883

  9. Oli Bartsch uploaded patch set 11 09/09/22, 08:09

  10. Oli Bartsch voted on patch set 11 V +1 CR +1 09/09/22, 08:09

  11. Andreas Kienast voted on patch set 11 V +1 CR +1 09/09/22, 08:12

  12. Benjamin Franzke commented on patch set 11 CR -1 09/09/22, 08:17

    dashboard.scss:1

    Why is this import added all over the place? Doesn't seem to be required.

    form.scss:640

    temporary comments? or can this be removed?

    _main.scss:371

    Nice, dark mode adaption! 😊 Let's mention that explicitly in the commit message, well, maybe that's meant by "They now look unified, by day and night."?
  13. core-ci voted on patch set 11 V +1 09/09/22, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30887

  14. Benjamin Kott commented on patch set 11 09/09/22, 08:27

    dashboard.scss:1 Reply

    yes, problem is that the need calc functions in the variables. tint and shade. so everywhere where the vars are used it's nessesary for now. can be cleaned up later as soon as we have a real solution for global variables but is too much overhead for just getting started.

    form.scss:640 Reply

    good catch can be removed.

    _main.scss:371 Reply

    we don't have full darkmode support and can start on some components after they have been cleaned up. I want to avoid the term to don't raise false expectations.
  15. Andreas Kienast uploaded patch set 12 09/09/22, 08:28

  16. Benjamin Franzke commented on patch set 11 CR -1 09/09/22, 08:30

    dashboard.scss:1 Reply

    I see, but can't we import @import "../../node_modules/bootstrap/scss/functions"; in Build/Sources/Sass/variables/_main.scss where the variables are defined that use such variables. Makes it clear why the dependency is addded.

    _main.scss:371 Reply

    Ack
  17. Andreas Kienast commented on patch set 12 09/09/22, 08:35

    dashboard.scss:1 Reply

    I just tried that and can't compile the CSS of EXT:adminpanel: > Fatal error: Error: Undefined mixin.
  18. core-ci voted on patch set 12 V +1 09/09/22, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30888

  19. Benjamin Kott commented on patch set 12 09/09/22, 08:38

    dashboard.scss:1 Reply

    will clean it up in a later patch and bring more structure to it. there is a lot to improve down the road. some already have functions loaded and some not. would leave it like that for the moment as temporary workaround. in general we want to have the variables exposed once but we need to extend the set first to see what else we need
  20. Benni Mack commented on patch set 12 09/09/22, 08:42

    dashboard.scss:1 Reply

    Fair enough I'd say, we need to cleanup the structure properly anyways

    form.scss:640 Reply

    Done
  21. Oli Bartsch voted on patch set 12 V +1 CR +1 09/09/22, 08:45

  22. Benjamin Franzke commented on patch set 12 09/09/22, 08:58

    dashboard.scss:1 Reply

    Ack.
  23. Andreas Kienast voted on patch set 12 V +1 CR +1 09/09/22, 09:05

  24. Andreas Kienast voted on patch set 12 V +2 CR +2 09/09/22, 09:14

  25. Andreas Kienast merged patch set 13 09/09/22, 09:14