Review main Abandoned

75660[TASK] Highlight save button as primary action once edited

Annett Jähnichen CR 0 V 0 Normal +66 −2 updated 10/09/23, 07:25

Commit message

Highlight the save action as primary item in edit views,
once the backend user has started to change to the content.

With content being changed, the save actions can be assumed
to be the primary user intent.

Note: upon opening a document the user might only want to
view, without performing changed, so save might not always
be the primary user intent. Therefore the btn-primary class
is added on demand.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 15

Review log 2230

Show 35 earlier messages
  1. Annett Jähnichen uploaded patch set 1 09/08/22, 11:27

  2. core-ci voted on patch set 1 V +1 09/08/22, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30808

  3. Oli Bartsch updated the commit message in patch set 2 09/08/22, 11:58

  4. core-ci voted on patch set 2 V +1 09/08/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30812

  5. Annett Jähnichen uploaded patch set 3 09/08/22, 12:52

  1. Annett Jähnichen updated the commit message in patch set 4 09/08/22, 12:54

  2. core-ci voted on patch set 3 V +1 09/08/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30815

  3. core-ci voted on patch set 4 V +1 09/08/22, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30816

  4. Oli Bartsch commented on patch set 4 09/08/22, 14:27

    Further places with a "save" button in the docheader: - Mfa configuration - Site configuration - User settings - Constant Editor - Form Editor - Access module (Permissions) - Edit file content
  5. Benni Mack commented on patch set 4 CR -1 09/08/22, 15:05

    Needs a Feature.rst
  6. Benjamin Franzke commented on patch set 4 09/08/22, 15:52

    Reply

    yea, well, or even better: make it a TASK. I think it's not a FEATURE after all.
  7. Annett Jähnichen uploaded patch set 5 09/08/22, 16:03

  8. Benjamin Franzke commented on patch set 5 09/08/22, 16:04

    Ok, so the reasoning (taken from the ticket) for this change is: > As an editor, > I want to find the Save Button quick, > so I can speed up my work, by not reading every button label, to find the correct action to use. > … > the most important and most used action is highlighted I think this user story is a bit too oversimplified. Upon opening a document, there is no such action that is the "correct" one. I think the story should read: As an editor I do only want to find the save button quick, once I have actually made any changes to the content. That means: The save button should only be highlighted once the document has changed (we have state handling that covers that). Do you agree?
  9. Annett Jähnichen commented on patch set 5 09/08/22, 16:05

    Reply

    Changed to TASK

    Reply

    done
  10. core-ci voted on patch set 5 V +1 09/08/22, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30842

  11. Benjamin Franzke voted on patch set 5 CR -1 09/08/22, 16:55

  12. Oli Bartsch commented on patch set 5 09/08/22, 17:04

    Reply

    Actually the state handling in FormEngine is not really reliable. It basically only works by setting "has-change" classes to elements. Also I think we don't have state handling in the other components at all.
  13. Annett Jähnichen commented on patch set 5 09/08/22, 17:05

    Reply

    I understand what you're getting at, but how do we handle the forms that don't have "state handling" yet and don't have required fields, like Scheduler Task or Permission Settings, File Content or File Rename. I would like to have a unified solution for all of them.
  14. Benjamin Franzke uploaded patch set 6 09/13/22, 19:31

  15. Benjamin Franzke commented on patch set 6 09/13/22, 19:31

    Reply

    > Actually the state handling in FormEngine is not really reliable Yes, we don't have full state tracking yet, but the state handling should suffice. we have – the "change" event that is triggered by all components as convention – should suffice to easily fullfill what I've outlined. See changes in patchset 6. There is only one exception, which is EXT:form, which unfortunately always does it own things. See patchset 6 for an adaption of that module.
  16. core-ci voted on patch set 6 V +1 09/13/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31066

  17. Oli Bartsch commented on patch set 6 09/21/22, 15:20

    Reply

    I had a quick look at the current patchset and what I think is missing is that the highlighting doesn't get reset when the "form state" is no longer "dirty" (no changes to the element left).
  18. Benjamin Franzke commented on patch set 6 09/22/22, 08:07

    Reply Unresolved

    yup, but that's a general issue in FormEngine. We also receive the "Do you want to close without saving?" in that case, although there is nothing to save. That what I meant with "we have basic state handling, but no full state tracking". In my opinion that's something which would be nice to be improved anyway – but for sure, a highlighted button would make this missing tracking more prevalent, so I understand if you feel like there is a difference between these cases and qualify it as "missing feature". So, well, fine with me to delay btn-highlighting until we have full state tracking.
  19. Annett Jähnichen uploaded patch set 7 V +1 11/29/22, 19:39

  20. core-ci voted on patch set 7 V -1 11/29/22, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34371

  21. core-ci voted on patch set 7 V +1 11/29/22, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34371

  22. Benni Mack wrote 11/30/22, 09:18

    Removed reviewer Benni Mack.
  23. Oliver Klee commented on patch set 7 10/08/23, 13:43

    How should we proceed here?
  24. Annett Jähnichen commented on patch set 7 10/09/23, 07:24

    Reply Unresolved

    I would discard the change for the time being, as we have not yet arrived at a uniformly good solution here. Perhaps there will be potential or need for this again in the future if there is an autosave function in the backend.
  25. Annett Jähnichen abandoned the change 10/09/23, 07:25

    I would discard the change for the time being, as we have not yet arrived at a uniformly good solution here.