75661[BUGFIX] Do not render clipboard errors as notification
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1620
-
Andreas Kienast uploaded patch set 1 09/08/22, 11:47
-
Oli Bartsch voted on patch set 1 V +1 CR +1 09/08/22, 11:55
-
core-ci voted on patch set 1 V +1 09/08/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30810
-
Benjamin Franzke commented on patch set 1 CR -1 09/08/22, 12:28
-
Andreas Kienast uploaded patch set 2 09/08/22, 13:14
-
Andreas Kienast commented on patch set 2 09/08/22, 13:15
clipboard-panel.ts:94ReplyDone -
Benjamin Franzke voted on patch set 2 CR +1 09/08/22, 13:22
-
core-ci voted on patch set 2 V +1 09/08/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30818
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/08/22, 13:24
-
Benjamin Franzke commented on patch set 2 V -1 09/08/22, 13:33
Hm.. still getting "An error occurred while fetching clipboard data" sometimes using "Fast 3G" throttling in google chrome. -
Andreas Kienast commented on patch set 2 09/08/22, 13:39
Reply
I can reproduce this when clicking "wildly" in the page tree. I can solve this by binding to the "unload" event instead. Do you have objections to this? -
Andreas Kienast uploaded patch set 3 09/08/22, 14:19
-
Andreas Kienast uploaded patch set 4 09/08/22, 14:20
-
core-ci voted on patch set 3 V +1 09/08/22, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30825
-
Benjamin Franzke voted on patch set 4 V +1 CR +1 09/08/22, 14:30
-
core-ci voted on patch set 4 V +1 09/08/22, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30827
-
Benni Mack voted on patch set 4 V +1 CR +1 09/08/22, 14:32
-
Oli Bartsch voted on patch set 4 V +1 CR +1 09/08/22, 14:34
-
Andreas Kienast voted on patch set 4 V +2 CR +2 09/08/22, 14:34
-
Andreas Kienast merged patch set 5 09/08/22, 14:35
clipboard-panel.ts:94