Review main Merged

75661[BUGFIX] Do not render clipboard errors as notification

Andreas Kienast CR +2 V +2 Easy +19 −13 updated 09/08/22, 14:35

Commit message

If a backend user switches pages in the list module right after the
clipboard is being loaded, the error message "An error occurred while
fetching clipboard data" may arise as a "global" notification which is
technically correct but confuses users.

To relax the situation, the error message is now rendered as a regular
alert box where the clipboard is expected to be and only if there is a
real error.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1620

  1. Andreas Kienast uploaded patch set 1 09/08/22, 11:47

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 09/08/22, 11:55

  3. core-ci voted on patch set 1 V +1 09/08/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30810

  4. Benjamin Franzke commented on patch set 1 CR -1 09/08/22, 12:28

    clipboard-panel.ts:94

    This event handler causes a memory leak for the request object. Should be removed with window.removeEventListener e.g. in request.finally()
  5. Andreas Kienast uploaded patch set 2 09/08/22, 13:14

  6. Andreas Kienast commented on patch set 2 09/08/22, 13:15

    clipboard-panel.ts:94 Reply

    Done
  7. Benjamin Franzke voted on patch set 2 CR +1 09/08/22, 13:22

  8. core-ci voted on patch set 2 V +1 09/08/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30818

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 09/08/22, 13:24

  10. Benjamin Franzke commented on patch set 2 V -1 09/08/22, 13:33

    Hm.. still getting "An error occurred while fetching clipboard data" sometimes using "Fast 3G" throttling in google chrome.
  11. Andreas Kienast commented on patch set 2 09/08/22, 13:39

    Reply

    I can reproduce this when clicking "wildly" in the page tree. I can solve this by binding to the "unload" event instead. Do you have objections to this?
  12. Andreas Kienast uploaded patch set 3 09/08/22, 14:19

  13. Andreas Kienast uploaded patch set 4 09/08/22, 14:20

  14. core-ci voted on patch set 3 V +1 09/08/22, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30825

  15. Benjamin Franzke voted on patch set 4 V +1 CR +1 09/08/22, 14:30

  16. core-ci voted on patch set 4 V +1 09/08/22, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30827

  17. Benni Mack voted on patch set 4 V +1 CR +1 09/08/22, 14:32

  18. Oli Bartsch voted on patch set 4 V +1 CR +1 09/08/22, 14:34

  19. Andreas Kienast voted on patch set 4 V +2 CR +2 09/08/22, 14:34

  20. Andreas Kienast merged patch set 5 09/08/22, 14:35