75662[DOCS] Improve doc comments for events for modifying flex form parsing
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Oli Bartsch +1
-
Verified V +2 Done
- Lina Wolf +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Configuration/Event/AfterFlexFormDataStructureIdentifierInitializedEvent.php13+18 −2
- typo3/sysext/core/Classes/Configuration/Event/AfterFlexFormDataStructureParsedEvent.php4+9 −0
- typo3/sysext/core/Classes/Configuration/Event/BeforeFlexFormDataStructureIdentifierInitializedEvent.php2+18 −0
- typo3/sysext/core/Classes/Configuration/Event/BeforeFlexFormDataStructureParsedEvent.php2+11 −0
Review log 2029
Show 24 earlier messages
-
Lina Wolf uploaded patch set 1 09/08/22, 13:16
-
Lina Wolf marked it work in progress 09/08/22, 13:16
-
core-ci voted on patch set 1 V -1 09/08/22, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30819
-
core-ci commented on patch set 1 09/09/22, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30819
-
Lina Wolf uploaded patch set 2 09/11/22, 10:50
-
Lina Wolf uploaded patch set 3 09/11/22, 10:52
-
core-ci voted on patch set 2 V -1 09/11/22, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30960
-
core-ci voted on patch set 3 V +1 09/11/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30961
-
Lina Wolf marked it ready for review 09/11/22, 17:23
-
Oliver Klee commented on patch set 3 09/11/22, 18:30
-
Oli Bartsch commented on patch set 3 09/12/22, 12:14
AfterFlexFormDataStructureIdentifierInitializedEvent.php:22which isAfterFlexFormDataStructureIdentifierInitializedEvent.php:53two whitespacesAfterFlexFormDataStructureIdentifierInitializedEvent.php:91Since this code comment is not rendered by docs, let's remove the syntax highlighting annotations. Also not quite sure if we should just copy the content from changelogs into the PHP classes. -
Lina Wolf commented on patch set 3 09/12/22, 15:01
AfterFlexFormDataStructureIdentifierInitializedEvent.php:91ReplyOn contrary, the code here is rendered in the documentation. Just like we render the ViewHelper reference from the the Doc comments in the ViewHelper classes we render the comments from all Events into the Events reference. I agree with removing the :php: though marking it as code by backticks is sufficient. -
Lina Wolf rebased onto patch set 4 09/13/22, 17:46
-
core-ci voted on patch set 4 V +1 09/13/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31063
-
Lina Wolf uploaded patch set 5 09/13/22, 17:56
-
Lina Wolf commented on patch set 5 09/13/22, 17:57
AfterFlexFormDataStructureIdentifierInitializedEvent.php:22ReplyDoneAfterFlexFormDataStructureIdentifierInitializedEvent.php:53ReplyDoneAfterFlexFormDataStructureIdentifierInitializedEvent.php:91ReplyDoneBeforeFlexFormDataStructureIdentifierInitializedEvent.php:101ReplyDone -
core-ci voted on patch set 5 V +1 09/13/22, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31064
-
Oli Bartsch commented on patch set 5 09/15/22, 12:57
AfterFlexFormDataStructureIdentifierInitializedEvent.php:91ReplyThis sounds really interesting, I wasn't aware of this. Where can I find the rendered version? -
Oli Bartsch commented on patch set 5 09/15/22, 13:04
AfterFlexFormDataStructureIdentifierInitializedEvent.php:53Replystill two whitespacesAfterFlexFormDataStructureIdentifierInitializedEvent.php:80I suggest to replace this with "Allows to"AfterFlexFormDataStructureParsedEvent.php:46Could we please remove them here and in the other comments as well?AfterFlexFormDataStructureParsedEvent.php:55I suggest to replace this with "Allows to"BeforeFlexFormDataStructureParsedEvent.php:54two whitespaces -
Lina Wolf uploaded patch set 6 09/15/22, 13:22
-
Lina Wolf uploaded patch set 7 09/15/22, 13:23
-
Lina Wolf uploaded patch set 8 09/15/22, 13:28
-
Lina Wolf commented on patch set 8 09/15/22, 13:29
AfterFlexFormDataStructureIdentifierInitializedEvent.php:53ReplyNow it should really be goneAfterFlexFormDataStructureIdentifierInitializedEvent.php:80ReplyDoneAfterFlexFormDataStructureIdentifierInitializedEvent.php:91ReplyAfterFlexFormDataStructureParsedEvent.php:46ReplyDoneAfterFlexFormDataStructureParsedEvent.php:55ReplyDoneBeforeFlexFormDataStructureParsedEvent.php:54ReplyDone -
core-ci voted on patch set 7 V +1 09/15/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31118
-
core-ci voted on patch set 6 V +1 09/15/22, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31117
-
core-ci voted on patch set 8 V +1 09/15/22, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31119
-
Oli Bartsch voted on patch set 8 V +1 CR +1 09/15/22, 13:43
-
Lina Wolf commented on patch set 8 V +2 CR +2 09/15/22, 13:44
Contains only documentation changes -
Lina Wolf merged patch set 9 09/15/22, 13:44
BeforeFlexFormDataStructureIdentifierInitializedEvent.php:101