Review main Merged

75663[BUGFIX] Properly evaluate whether toolbar item provides a dropdown

Oli Bartsch CR +2 V +2 Easy +43 −2 updated 09/08/22, 15:19

Commit message

The ToolbarItemInterface requires the methods
hasDropDown() as well as getDropDown(). Since
#98214 the evaluation whether a toolbar item
provides a dropdown is done in Fluid, using the
corresponding magic "{toolbarItem.dropDown}".

Fluid however first checks for a "Getter" and
therefore uses the getDropDown() method instead
of the hasDropDown() method to determine whether
a toolbar item provides a dropdown. This led to
display errors in case a toolbar item only provides
a dropdown for some use cases as this was now
always used.

This is now fixed using a dedicated conditional
ViewHelper.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Oli Bartsch uploaded patch set 1 09/08/22, 13:23

  2. core-ci voted on patch set 1 V +1 09/08/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30820

  3. Andreas Kienast commented on patch set 1 CR -1 09/08/22, 13:46

    What?
  4. Oli Bartsch updated the commit message in patch set 2 09/08/22, 13:53

  5. Oli Bartsch commented on patch set 2 09/08/22, 13:54

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/08/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30822

  7. Andreas Kienast commented on patch set 2 V +1 CR +1 09/08/22, 14:33

    I don't like it, but it solves the issue and I have no better idea.
  8. Oli Bartsch commented on patch set 3 09/08/22, 15:07

    Published edit on patch set 2.
  9. Andreas Kienast voted on patch set 3 V +1 CR +1 09/08/22, 15:09

  10. core-ci voted on patch set 3 V +1 09/08/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30834

  11. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/08/22, 15:19

  12. Benjamin Franzke merged patch set 4 09/08/22, 15:19