Review main Merged

75664[BUGFIX] Prevent undefined array key error in StoragePermissionsAspect

Oli Bartsch CR +2 V +2 Easy +4 −0 updated 09/08/22, 16:16

Commit message

For not yet migrated filemount records, the
StoragePermissionsAspect previously triggered
an undefined array key since the new field "identifier"
(see #97922) might be empty or at least does not
contain the combined identifier with the ":" sign.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 910

  1. Oli Bartsch uploaded patch set 1 09/08/22, 14:20

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 09/08/22, 14:25

  3. core-ci voted on patch set 1 V +1 09/08/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30826

  4. Benni Mack voted on patch set 1 CR +1 09/08/22, 14:33

  5. Oliver Klee voted on patch set 1 CR +1 09/08/22, 16:12

  6. Oliver Klee commented on patch set 1 09/08/22, 16:12

    11.5 is not affected?
  7. Jochen Roth voted on patch set 1 V +1 CR +1 09/08/22, 16:13

  8. Andreas Kienast commented on patch set 1 09/08/22, 16:15

    Reply

    No. Please see the related ticket.
  9. Oli Bartsch voted on patch set 1 V +2 CR +2 09/08/22, 16:16

  10. Oli Bartsch merged patch set 2 09/08/22, 16:16