Review main Merged

75679[TASK] Unify badge rendering

Benjamin Kott CR +2 V +2 Normal +21 −57 updated 09/09/22, 11:00

Commit message

Badges are currently in an inconsistent state
and sometimes the severity it shows is not
related to the contents of the badge at all.

To resolve this we are removing all auto coloring
of badges. If a badge needs a meaningful severity
it must be set explicitly.

Badges are now also not extremely rounded by default
anymore. Except for the notification in the topbar,
there is no need to have them look like notification
bubbles.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 68

  1. Benjamin Kott uploaded patch set 1 09/09/22, 10:28

  2. core-ci voted on patch set 1 V +1 09/09/22, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30908

  3. Benjamin Kott uploaded patch set 2 09/09/22, 10:38

  4. core-ci voted on patch set 2 V +1 09/09/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30912

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 09/09/22, 10:48

  6. Susi Moog voted on patch set 2 V +1 CR +1 09/09/22, 10:58

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 09/09/22, 10:59

  8. Andreas Kienast merged patch set 3 09/09/22, 11:00