Review main Merged Breaking

75680[!!!][FEATURE] Add PSR-14 ModifyEditFormUserAccessEvent

Oli Bartsch CR +2 V +2 Hard +384 −142 updated 09/21/22, 15:02

Commit message

This introduces a new PSR-14 event, enabling
extension authors to modify the user access
decision for creating / editing a record in
FormEngine.

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/alt_doc.php']['makeEditForm_accessCheck']
which is therefore now removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1014

  1. Oli Bartsch uploaded patch set 1 09/09/22, 14:02

  2. core-ci voted on patch set 1 V -1 09/09/22, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30932

  3. Oli Bartsch uploaded patch set 2 09/12/22, 12:04

  4. core-ci voted on patch set 2 V -1 09/12/22, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30979

  5. Oli Bartsch uploaded patch set 3 09/21/22, 08:20

  6. core-ci voted on patch set 3 V +1 09/21/22, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31340

  7. Benni Mack commented on patch set 3 09/21/22, 11:12

    MockEventDispatcher.php:43

    addListener?
  8. Oli Bartsch uploaded patch set 4 09/21/22, 13:25

  9. Oli Bartsch commented on patch set 4 09/21/22, 13:25

    MockEventDispatcher.php:43 Reply

    Done
  10. core-ci voted on patch set 4 V +1 09/21/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31372

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 09/21/22, 14:14

  12. Benni Mack voted on patch set 4 V +1 CR +1 09/21/22, 14:48

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 09/21/22, 15:02

  14. Oli Bartsch merged patch set 5 09/21/22, 15:02