75683[TASK] Prevent undefined array key warnings in ext:adminpanel
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Anja Leichsenring +1
- Stefan Bürk +1
- Susi Moog +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Debug/Events.php+4 −3
- typo3/sysext/adminpanel/Classes/Modules/Debug/Log.php+2 −2
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php2+7 −6
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Info/PhpInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Info/RequestInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Info/UserIntInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+2 −2
- typo3/sysext/adminpanel/Classes/Modules/CacheModule.php+3 −2
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php2+15 −8
- typo3/sysext/adminpanel/Classes/Service/ModuleLoader.php+2 −2
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php+1 −1
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+3 −0
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+2 −2
Review log 2126
Show 1 earlier messages
-
Oliver Hader uploaded patch set 1 09/10/22, 12:03
-
core-ci voted on patch set 1 V +1 09/10/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30943
-
Stefan Bürk commented on patch set 1 09/10/22, 13:02
-
Stefan Bürk uploaded patch set 2 09/10/22, 13:02
-
Stefan Bürk commented on patch set 2 09/10/22, 13:02
PageTitle.php:81ReplyDone -
core-ci voted on patch set 2 V +1 09/10/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30945
-
Stefan Bürk voted on patch set 2 V +1 CR +1 09/10/22, 13:11
-
Simon Schaufelberger updated the commit message in patch set 3 09/10/22, 14:49
-
core-ci voted on patch set 3 V +1 09/10/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30948
-
Oliver Klee commented on patch set 3 09/10/22, 16:31
PreviewModule.php:49Are those array elements nullable, or are they optional? In case they are optional instead of nullable, the corresponding notation should look like this instead: * showHiddenPages?: bool, * simulateDate?: int, * showHiddenRecords?: bool, * showScheduledRecords?: bool, * simulateUserGroup?: int, * showFluidDebug?: bool This is documented here: https://phpstan.org/writing-php-code/phpdoc-types#array-shapes -
Oliver Hader commented on patch set 3 09/10/22, 18:11
PreviewModule.php:49ReplyThanks, indeed those are meant to be optional, not nullable. -
Oliver Hader uploaded patch set 4 09/10/22, 18:11
-
core-ci voted on patch set 4 V +1 09/10/22, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30953
-
Oliver Klee voted on patch set 4 CR +1 09/11/22, 10:09
-
Susi Moog voted on patch set 4 V +1 CR +1 09/15/22, 07:10
-
Benjamin Franzke commented on patch set 4 09/16/22, 10:04
AbstractModule.php:68Hm.. did psalm PHP complain about this line? It's a construct we use very often, and I don't see the issue… Replacing that with empty makes the code harder to read (IMO) and later/strict phpstan levels will complain about empty() not being typesafe (too general) condition. -
Oliver Hader commented on patch set 4 09/19/22, 11:44
AbstractModule.php:68ReplyPsalm complained about the line below - and did not anymore when using `empty` - sure, that is an internal issue with Psalm. → extracted issue with Psalm: https://psalm.dev/r/1ad02a92e4 However, using `empty` is the explicit form of what currently is evaluated here. In the future PhpStan might issues problems for mixed types as well. → extracted issue with PhpStan: https://phpstan.org/r/ed831730-cbec-47d0-9d19-46d6c3ffc4eb Anyway, I'm fine with keep the previous code (discarding this change). -
Oliver Hader uploaded patch set 5 09/19/22, 11:46
-
Oliver Hader commented on patch set 5 09/19/22, 11:47
AbstractModule.php:68ReplyDone -
core-ci voted on patch set 5 V +1 09/19/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31265
-
Oliver Klee voted on patch set 5 CR +1 09/19/22, 13:47
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 09/19/22, 16:44
-
Stefan Bürk voted on patch set 5 V +1 CR +1 09/19/22, 16:46
-
Susi Moog voted on patch set 5 V +1 CR +1 09/22/22, 05:36
-
Oli Bartsch voted on patch set 5 V +2 CR +2 09/22/22, 07:40
-
Oli Bartsch merged patch set 6 09/22/22, 07:40
PageTitle.php:81