Review main Merged

75685[TASK] Add notification when Grunt "watch" finished compilation

Jonas Eberle CR +2 V +2 Easy +9 −2 updated 09/16/22, 12:11

Commit message

This outputs a "bell" character to notify the developer that the "watch"
task has picked up and finished compilation of changes.

"bell" is meant to draw user attention and modern developer-oriented
terminals usually implement it by flashing the title bar or showing a
notification.
The action is usually configurable in the terminal settings.

This is basically https://www.npmjs.com/package/grunt-bell.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Jonas Eberle uploaded patch set 1 09/10/22, 13:04

  2. core-ci voted on patch set 1 V +1 09/10/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30946

  3. Jonas Eberle updated the commit message in patch set 2 09/10/22, 13:26

  4. core-ci voted on patch set 2 V +1 09/10/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30947

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/16/22, 12:08

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 09/16/22, 12:11

  7. Stefan Bürk merged patch set 3 09/16/22, 12:11