75687[TASK] Prevent undefined array key warnings in ext:dashboard
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- Christian Kuhn +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+12 −6
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php+7 −3
- typo3/sysext/dashboard/Classes/Widgets/CtaWidget.php+3 −0
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+6 −0
- typo3/sysext/dashboard/Classes/Dashboard.php+4 −3
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php4+2 −2
- typo3/sysext/dashboard/Classes/DashboardRepository.php+3 −3
- typo3/sysext/dashboard/Classes/WidgetApi.php2+1 −1
Review log 1115
-
Oliver Hader uploaded patch set 1 09/11/22, 15:29
-
core-ci voted on patch set 1 V -1 09/11/22, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30962
-
core-ci commented on patch set 1 09/11/22, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30962
-
Oliver Hader uploaded patch set 2 09/11/22, 18:35
-
core-ci voted on patch set 2 V +1 09/11/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30963
-
Oliver Klee commented on patch set 2 09/12/22, 10:49
DashboardInitializationService.php:246For the sake of the human reader, please also add the array keys: list<string|array{0: string, 1: string}>WidgetApi.php:28For the sake of the human reader, please also add the array keys: @return array{0: string, 1: string, 2: string, 3: string, 4: string} -
Oliver Hader commented on patch set 3 09/14/22, 18:41
Published edit on patch set 2. -
Oliver Hader commented on patch set 3 09/14/22, 18:42
DashboardInitializationService.php:64ReplyDoneDashboardInitializationService.php:246ReplyDoneWidgetApi.php:28ReplyDone -
core-ci voted on patch set 3 V +1 09/14/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31090
-
Oliver Klee voted on patch set 3 CR +1 09/14/22, 19:03
-
Susi Moog voted on patch set 3 V +1 CR +1 09/15/22, 12:22
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/16/22, 11:43
-
Stefan Bürk voted on patch set 3 V +1 CR +1 09/16/22, 11:45
-
Oliver Hader voted on patch set 3 V +2 CR +2 09/19/22, 13:27
-
Oliver Hader merged patch set 4 09/19/22, 13:27
DashboardInitializationService.php:64