Review main Merged

75687[TASK] Prevent undefined array key warnings in ext:dashboard

Oliver Hader CR +2 V +2 Normal +38 −18 updated 09/19/22, 13:27

Commit message

This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1115

  1. Oliver Hader uploaded patch set 1 09/11/22, 15:29

  2. core-ci voted on patch set 1 V -1 09/11/22, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30962

  3. core-ci commented on patch set 1 09/11/22, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30962

  4. Oliver Hader uploaded patch set 2 09/11/22, 18:35

  5. core-ci voted on patch set 2 V +1 09/11/22, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30963

  6. Oliver Klee commented on patch set 2 09/12/22, 10:49

    DashboardInitializationService.php:64

    For the sake of the human reader, please also add the array keys: list<string|array{0: string, 1: string}>

    DashboardInitializationService.php:246

    For the sake of the human reader, please also add the array keys: list<string|array{0: string, 1: string}>

    WidgetApi.php:28

    For the sake of the human reader, please also add the array keys: @return array{0: string, 1: string, 2: string, 3: string, 4: string}
  7. Oliver Hader commented on patch set 3 09/14/22, 18:41

    Published edit on patch set 2.
  8. Oliver Hader commented on patch set 3 09/14/22, 18:42

    DashboardInitializationService.php:64 Reply

    Done

    DashboardInitializationService.php:246 Reply

    Done

    WidgetApi.php:28 Reply

    Done
  9. core-ci voted on patch set 3 V +1 09/14/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31090

  10. Oliver Klee voted on patch set 3 CR +1 09/14/22, 19:03

  11. Susi Moog voted on patch set 3 V +1 CR +1 09/15/22, 12:22

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 09/16/22, 11:43

  13. Stefan Bürk voted on patch set 3 V +1 CR +1 09/16/22, 11:45

  14. Oliver Hader voted on patch set 3 V +2 CR +2 09/19/22, 13:27

  15. Oliver Hader merged patch set 4 09/19/22, 13:27