Review main Merged

75692[TASK] Streamline colors, correct contrast colors

Benjamin Kott CR +2 V +2 Expert +982 −1216 updated 04/11/23, 08:58

Commit message

The core currently uses a wide range of
state colors across the backend. This is
a mixture of defined colors for specific areas
and the global usage of the Bootstrap 5
theme colors.

The current state is a mixture of vibrant
and faded colors. The current implementation
results in false calculated contrast colors for
certain areas.

To resolve this we are now unifying all used
colors across the backend and streamline
the text color contrast calculation.

That needed several cleanups across the
backend regarding markup and CSS styles.
The result is a more harmonized look and
feel of the Backend.

Affected areas are:
- Alerts
- Badges
- Buttons
- Callouts
- Panels
- Modals
- Tables

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 78

Show 58 more files

Review log 3155

Show 1530 earlier messages
  1. Benjamin Kott uploaded patch set 1 09/12/22, 13:09

  2. core-ci voted on patch set 1 V -1 09/12/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30981

  3. Benjamin Kott uploaded patch set 2 09/13/22, 07:29

  4. core-ci voted on patch set 2 V -1 09/13/22, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31002

  5. Benjamin Kott uploaded patch set 3 09/13/22, 09:18

  6. core-ci voted on patch set 3 V -1 09/13/22, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31045

  7. Benjamin Kott uploaded patch set 4 09/13/22, 09:51

  8. core-ci voted on patch set 4 V +1 09/13/22, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31046

  9. Benjamin Kott uploaded patch set 5 09/13/22, 10:27

  10. core-ci voted on patch set 5 V +1 09/13/22, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31047

  11. Benjamin Kott uploaded patch set 6 09/13/22, 12:23

  12. core-ci voted on patch set 6 V +1 09/13/22, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31053

  13. Benjamin Kott uploaded patch set 7 09/13/22, 13:29

  14. core-ci voted on patch set 7 V -1 09/13/22, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31054

  15. Benjamin Kott uploaded patch set 8 09/13/22, 13:44

  16. Benjamin Kott uploaded patch set 9 09/13/22, 13:45

  17. core-ci voted on patch set 8 V -1 09/13/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31056

  18. core-ci voted on patch set 9 V +1 09/13/22, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31057

  19. Benjamin Kott uploaded patch set 10 09/14/22, 15:17

  20. core-ci voted on patch set 10 V -1 09/14/22, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31087

  21. Benjamin Kott uploaded patch set 11 09/15/22, 07:10

  22. core-ci voted on patch set 11 V +1 09/15/22, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31098

  23. Benjamin Kott uploaded patch set 12 09/15/22, 09:01

  24. core-ci voted on patch set 12 V -1 09/15/22, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31100

  25. Benjamin Kott uploaded patch set 13 09/15/22, 09:26

  26. core-ci voted on patch set 13 V -1 09/15/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31101

  27. Benjamin Kott uploaded patch set 14 09/15/22, 09:34

  28. Benjamin Kott uploaded patch set 15 09/15/22, 09:38

  29. core-ci voted on patch set 15 V +1 09/15/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31104

  30. core-ci voted on patch set 14 V -1 09/15/22, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31102

  1. Benjamin Kott updated the commit message in patch set 16 09/15/22, 10:04

  2. core-ci voted on patch set 16 V +1 09/15/22, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31107

  3. Benjamin Kott uploaded patch set 17 09/15/22, 10:12

  4. Andreas Kienast updated the commit message in patch set 18 09/15/22, 10:21

  5. core-ci voted on patch set 17 V +1 09/15/22, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31109

  6. core-ci voted on patch set 18 V +1 09/15/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31111

  7. Benjamin Kott uploaded patch set 19 09/15/22, 10:37

  8. core-ci voted on patch set 19 V +1 09/15/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31112

  9. Benjamin Kott uploaded patch set 20 09/15/22, 10:46

  10. core-ci voted on patch set 20 V +1 09/15/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31113

  11. Benjamin Kott uploaded patch set 21 09/15/22, 11:04

  12. core-ci voted on patch set 21 V +1 09/15/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31114

  13. Benjamin Kott uploaded patch set 22 09/16/22, 06:56

  14. core-ci voted on patch set 22 V +1 09/16/22, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31144

  15. Benjamin Kott uploaded patch set 23 09/16/22, 07:18

  16. core-ci voted on patch set 23 V +1 09/16/22, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31146

  17. Benjamin Kott uploaded patch set 24 09/16/22, 07:26

  18. Frank Nägler voted on patch set 24 V +1 CR +1 09/16/22, 07:31

  19. core-ci voted on patch set 24 V +1 09/16/22, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31147

  20. Benni Mack commented on patch set 24 V +2 CR +2 09/16/22, 09:24

    Thanks for the clean up
  21. Benni Mack merged patch set 25 09/16/22, 09:24

  22. Oli Bartsch commented on patch set 24 09/16/22, 09:26

    extension-scanner.ts:191 Unresolved

    This might be due to CSS and not related to the JS changes but when scanning extensions, the progress bar in the panel header is not visible until errors are found.

    SubSection.html:3 Unresolved

    Where is this class used? I couldn't find any reference "grepping" in core
  23. Oli Bartsch commented on patch set 25 09/16/22, 09:47

  24. Andreas Kienast commented on patch set 25 09/20/22, 13:26

    PanelItem.html:6 Unresolved

    post -1: this breaks the document filter
  25. Benjamin Franzke commented on patch set 25 01/18/23, 09:10

    _panel.scss:85 Unresolved

    Can anyone remember the reason to add overflow:hidden here? This caused accordions in image processing environment test to not be visible. Please see https://forge.typo3.org/issues/99590