75695[BUGFIX] Revert modified cache handling in form framework
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Elias Häußler +1
-
Verified V +2 Done
- Oliver Hader +2
- Elias Häußler +1
- core-ci +1 CI
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon+5 −0
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+5 −9
- typo3/sysext/form/Classes/Core/FormRequestHandler.phpdeleted+0 −276
- typo3/sysext/form/Classes/Domain/Factory/FormFactoryInterface.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+25 −22
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+56 −29
- typo3/sysext/form/Configuration/Services.yaml+0 −3
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+54 −42
- typo3/sysext/form/Tests/Unit/Core/FormRequestHandlerTest.phpdeleted+0 −230
- typo3/sysext/form/ext_localconf.php+1 −3
Review log 68
-
Oliver Hader uploaded patch set 1 09/12/22, 19:13
-
Oliver Hader updated the commit message in patch set 2 09/12/22, 19:16
-
core-ci voted on patch set 2 V +1 09/12/22, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30987
-
core-ci voted on patch set 1 V +1 09/12/22, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30986
-
Elias Häußler commented on patch set 2 V +1 CR +1 09/12/22, 19:58
Tested locally with EXT:form_consent which failed since #93887. LGTM 👍 -
Oliver Hader commented on patch set 2 V +1 09/12/22, 20:46
A plain test in v11 using the Extbase plugin looked good on my side as well. -
Oliver Hader voted on patch set 2 V +2 CR +2 09/13/22, 07:50
-
Oliver Hader merged patch set 3 09/13/22, 07:50