Review 11.5 Merged

75695[BUGFIX] Revert modified cache handling in form framework

Oliver Hader CR +2 V +2 Hard +148 −616 updated 09/13/22, 07:50

Commit message

The changes applied for issue #93887 introduced a bunch of
regressions, which were partially addressed. However, there
are still much more issues related to cache handling that
have been introduced by mentioned change.

#97977: This reverts commit f8fa1be34eb85cb67f6c5822576541c08b2b512a
#98023: This reverts commit 8129d55e6b56ce23263dd726ddef2e20d017f23c
#93887: This reverts commit 9f933f2cf1c05709962c9efa2dd1951e7ad9a6a7

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 68

  1. Oliver Hader uploaded patch set 1 09/12/22, 19:13

  2. Oliver Hader updated the commit message in patch set 2 09/12/22, 19:16

  3. core-ci voted on patch set 2 V +1 09/12/22, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30987

  4. core-ci voted on patch set 1 V +1 09/12/22, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30986

  5. Elias Häußler commented on patch set 2 V +1 CR +1 09/12/22, 19:58

    Tested locally with EXT:form_consent which failed since #93887. LGTM 👍
  6. Oliver Hader commented on patch set 2 V +1 09/12/22, 20:46

    A plain test in v11 using the Extbase plugin looked good on my side as well.
  7. Oliver Hader voted on patch set 2 V +2 CR +2 09/13/22, 07:50

  8. Oliver Hader merged patch set 3 09/13/22, 07:50