Review main Merged

75697[BUGFIX] Use array key access guard in WorkspaceVersionRecordsCommand

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 09/16/22, 12:04

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Daniel Siepmann uploaded patch set 1 09/13/22, 03:13

  2. Daniel Siepmann uploaded patch set 2 09/13/22, 03:16

  3. core-ci voted on patch set 1 V -1 09/13/22, 03:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30992

  4. core-ci voted on patch set 2 V +1 09/13/22, 03:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30993

  5. Stefan Bürk commented on patch set 2 CR -1 09/14/22, 13:20

    Change in behaviour
    Can we make this a little bit smaller, to avoid line breaking ? Something like: * [BUGFIX] Use array key access guard in WorkspaceVersionRecordsCommand * [BUGFIX] Ensure proper array key access in WorkspaceVersionRecordsCommand ?

    WorkspaceVersionRecordsCommand.php:304

    This is a change in behaviour, see: https://3v4l.org/eqqJV Better use ``` if (!($verRec['_CURRENT_VERSION'] ?? false)) {...} ``` here
  6. Daniel Siepmann uploaded patch set 3 09/14/22, 15:46

  7. Daniel Siepmann commented on patch set 3 09/14/22, 15:47

    Reply

    Should be solved by now.

    Reply

    Done, used 1st as 2nd is also to long

    WorkspaceVersionRecordsCommand.php:304 Reply

    Sure, Done. Thought I did use the same as in another approved patch, which follows your suggestion. Not sure what did go wrong. Thanks.
  8. core-ci voted on patch set 3 V +1 09/14/22, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31088

  9. Oliver Klee voted on patch set 3 CR +1 09/14/22, 16:02

  10. Christian Kuhn rebased onto patch set 4 09/16/22, 11:45

  11. Stefan Bürk commented on patch set 4 09/16/22, 11:48

    Reply

    Done
  12. Stefan Bürk voted on patch set 4 V +1 CR +1 09/16/22, 11:49

  13. Oliver Klee voted on patch set 4 CR +1 09/16/22, 11:57

  14. core-ci voted on patch set 4 V +1 09/16/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31182

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 09/16/22, 12:04

  16. Christian Kuhn merged patch set 5 09/16/22, 12:04