Review 11.5 Merged

75698[TASK] Resolve cgl violations in php files

Stefan Bürk CR +2 V +2 Hard +137 −137 updated 09/13/22, 05:46

Commit message

With #98331 friendsofphp/php-cs-fixer has been raised in
v11. However, pre-merge ci only scans for cgl in changed
php files. Thus no scan has been run on all php files and
cgl violations were not detected. Nightly revealed them.

This change runs cgl fix on all files to align them to the
current rules and style.

Used commands:

> Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 50

Show 30 more files

Review log 710

  1. Stefan Bürk uploaded patch set 1 09/13/22, 05:09

  2. core-ci voted on patch set 1 V +1 09/13/22, 05:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30997

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/13/22, 05:20

  4. Stefan Bürk commented on patch set 1 09/13/22, 05:21

  5. core-ci commented on patch set 1 09/13/22, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30999

  6. Stefan Bürk updated the commit message in patch set 2 09/13/22, 05:38

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 09/13/22, 05:41

  8. core-ci voted on patch set 2 V +1 09/13/22, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31000

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 09/13/22, 05:46

  10. Stefan Bürk merged patch set 3 09/13/22, 05:46