Review main Merged

75699[FEATURE] Refactor Live Search UI and introduce keyboard shortcut to open

Andreas Kienast CR +2 V +2 Expert +676 −414 updated 09/16/22, 15:34

Commit message

The live search located at the top right side of the TYPO3 backend now
uses a modal window to render the search controls and the results.
As more space is now available, the amount of search results is
increased to 50 records per search.

The modal may be opened via a keyboard shortcut by pressing the Shift
key twice in a row.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • Benjamin Kott +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 37

Show 17 more files

Review log 4971

Show 3046 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/13/22, 05:09

  2. core-ci voted on patch set 1 V -1 09/13/22, 05:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30998

  3. Andreas Kienast uploaded patch set 2 09/14/22, 10:28

  4. core-ci voted on patch set 2 V -1 09/14/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31078

  5. Benjamin Franzke uploaded patch set 3 09/14/22, 12:10

  6. core-ci voted on patch set 3 V -1 09/14/22, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31082

  7. Andreas Kienast uploaded patch set 4 09/14/22, 13:07

  8. core-ci voted on patch set 4 V -1 09/14/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31084

  9. Andreas Kienast uploaded patch set 5 09/14/22, 13:44

  10. core-ci voted on patch set 5 V -1 09/14/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31085

  11. Simon Schaufelberger commented on patch set 5 09/14/22, 21:25

    wow, this is really cool! The currently hovered item has the wrong z-index as it overlaps the input field but my first impression is: awesome!
  12. Simon Schaufelberger commented on patch set 5 09/14/22, 21:30

    Please also make sure the application information panel has no horizontal scrollbar which is the case for me.
  13. Andreas Kienast commented on patch set 5 09/15/22, 06:42

    Reply

    That's strange, I cannot reproduce that. There is an issue with the bookmarks menu that triggers a horizontal scrollbar for the whole document if it gets too wide, tho.

    Reply

    Thanks for testing. I'm already aware of that issue, I'll check again once the missing features were added and tests are green again.
  14. Andreas Kienast uploaded patch set 6 09/15/22, 09:58

  15. Andreas Kienast uploaded patch set 7 09/15/22, 09:59

  16. core-ci voted on patch set 6 V +1 09/15/22, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31105

  17. Andreas Kienast uploaded patch set 8 09/15/22, 10:12

  18. Andreas Kienast uploaded patch set 9 09/15/22, 10:14

  19. core-ci voted on patch set 7 V +1 09/15/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31106

  20. core-ci voted on patch set 9 V +1 09/15/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31110

  21. core-ci voted on patch set 8 V +1 09/15/22, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31108

  22. Simon Schaufelberger voted on patch set 9 V +1 CR +1 09/15/22, 12:46

  23. Andreas Kienast commented on patch set 9 CR -1 09/15/22, 13:54

    working on something, will lift -1 soon
  24. Andreas Kienast uploaded patch set 10 09/15/22, 14:19

  25. Simon Schaufelberger voted on patch set 10 V +1 CR +1 09/15/22, 14:27

  26. core-ci voted on patch set 10 V -1 09/15/22, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31120

  27. Andreas Kienast uploaded patch set 11 09/15/22, 14:45

  28. Andreas Kienast uploaded patch set 12 09/15/22, 14:53

  29. core-ci voted on patch set 11 V +1 09/15/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31121

  30. core-ci voted on patch set 12 V +1 09/15/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31122

  31. Andreas Kienast uploaded patch set 13 09/15/22, 17:21

  32. core-ci voted on patch set 13 V +1 09/15/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31123

  33. Simon Schaufelberger voted on patch set 13 V +1 CR +1 09/15/22, 17:45

  34. Simon Schaufelberger commented on patch set 13 V -1 09/15/22, 18:15

    I tried to compile the js avain to verify it but this is how the hints array looks when I output it in the console: 0: "#page:Home will search for all pages with the title \"Home\"" 1: undefined 2: undefined
  35. Simon Schaufelberger commented on patch set 13 V +1 09/15/22, 18:19

    Reply

    oh, forgot to clear the cache ;)
  36. Andreas Kienast uploaded patch set 14 09/16/22, 06:57

  37. core-ci voted on patch set 14 V +1 09/16/22, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31145

  38. Andreas Kienast commented on patch set 14 CR -1 09/16/22, 07:40

    Benji makes things nicer
  39. Benjamin Kott uploaded patch set 15 09/16/22, 08:42

  40. core-ci voted on patch set 15 V +1 09/16/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31153

  41. Andreas Kienast commented on patch set 15 CR -2 09/16/22, 08:59

    Benji and I are still working on it
  42. Andreas Kienast uploaded patch set 16 09/16/22, 09:02

  43. core-ci voted on patch set 16 V +1 09/16/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31157

  44. Benjamin Kott uploaded patch set 17 09/16/22, 10:49

  45. Andreas Kienast voted on patch set 17 CR 0 09/16/22, 10:50

  46. Benjamin Kott uploaded patch set 18 09/16/22, 10:51

  1. Andreas Kienast uploaded patch set 19 09/16/22, 11:02

  2. core-ci voted on patch set 17 V +1 09/16/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31169

  3. core-ci voted on patch set 18 V +1 09/16/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31171

  4. core-ci voted on patch set 19 V +1 09/16/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31174

  5. Simon Schaufelberger commented on patch set 19 09/16/22, 11:22

    Clicking on the bookmark icon adds a scrollbar now because the width to the right is slightly bigger than when closed.
  6. Simon Schaufelberger commented on patch set 19 09/16/22, 11:24

    Reply

    my user nams is simply "Admin"
  7. Andreas Kienast commented on patch set 19 09/16/22, 11:29

    Reply

    Can confirm. Bootstrap should take care of this, IIRC. Looks like an off-by-one issue.
  8. Andreas Kienast uploaded patch set 20 09/16/22, 11:33

  9. core-ci voted on patch set 20 V +1 09/16/22, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31179

  10. Simon Schaufelberger commented on patch set 20 09/16/22, 11:44

    how about selecting the whole query input when opening the modal again? This is also what phpstorm is doing to be able to enter a different search term without deleting the previously entered search term.
  11. Andreas Kienast commented on patch set 20 09/16/22, 11:56

    Reply

    Ack. Is added with the next push.
  12. Andreas Kienast uploaded patch set 21 09/16/22, 12:03

  13. Andreas Kienast commented on patch set 21 09/16/22, 12:03

    Reply

    Done

    Reply

    Done
  14. Simon Schaufelberger voted on patch set 21 V +1 CR +1 09/16/22, 12:11

  15. core-ci voted on patch set 21 V +1 09/16/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31186

  16. Benjamin Kott voted on patch set 21 V +1 CR +1 09/16/22, 12:18

  17. Andreas Kienast uploaded patch set 22 09/16/22, 12:25

  18. Andreas Kienast commented on patch set 22 09/16/22, 12:25

    rebased only
  19. Benjamin Kott voted on patch set 22 V +1 CR +1 09/16/22, 12:30

  20. core-ci voted on patch set 22 V +1 09/16/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31190

  21. Simon Schaufelberger voted on patch set 22 V +1 CR +1 09/16/22, 12:43

  22. Jonas Eberle voted on patch set 22 V +1 09/16/22, 13:18

  23. Benni Mack commented on patch set 22 V +1 CR +1 09/16/22, 15:18

    Although I don't like the sliding down of the modal, I think we can move forward here. In general, I'll be working on a "Rich Snippet Result" concept to further improve the results.
  24. Andreas Kienast voted on patch set 22 V +2 CR +2 09/16/22, 15:34

  25. Andreas Kienast merged patch set 23 09/16/22, 15:34