75699[FEATURE] Refactor Live Search UI and introduce keyboard shortcut to open
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Jonas Eberle +1
- Benjamin Kott +1
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 37
- Build/Sources/Sass/component/_autocomplete.scss+0 −8
- Build/Sources/Sass/component/_livesearch.scssnew+55 −0
- Build/Sources/Sass/component/_modal.scss+1 −2
- Build/Sources/Sass/scaffold/_scaffold.scss+1 −3
- Build/Sources/Sass/scaffold/_toolbar.scss+0 −96
- Build/Sources/Sass/scaffold/_topbar.scss+0 −32
- Build/Sources/Sass/typo3/_main_form.scss+17 −12
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/live-search/element/result-container.tsnew+106 −0
- Build/Sources/TypeScript/backend/live-search/element/result-item.tsnew+81 −0
- Build/Sources/TypeScript/backend/live-search/element/show-all.tsnew+48 −0
- Build/Sources/TypeScript/backend/live-search/double-shift-trigger.tsnew+39 −0
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+135 −178
- Build/Sources/TypeScript/backend/module-menu.ts+0 −1
- Build/Sources/TypeScript/backend/toolbar.ts+1 −2
- typo3/sysext/backend/Classes/Backend/ToolbarItems/LiveSearchToolbarItem.php+2 −2
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+4 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+9 −4
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −0
Show 17 more files
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.html+6 −17
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItem.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result-container.jsnew+26 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result-item.jsnew+23 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/show-all.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/double-shift-trigger.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+16 −18
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98348-LiveSearchMovedIntoModalWindow.rstnew+28 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+0 −3
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+6 −0
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.php+3 −0
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/SearchCest.php+33 −28
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
Review log 4971
Show 3046 earlier messages
-
Andreas Kienast uploaded patch set 1 09/13/22, 05:09
-
core-ci voted on patch set 1 V -1 09/13/22, 05:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30998
-
Andreas Kienast uploaded patch set 2 09/14/22, 10:28
-
core-ci voted on patch set 2 V -1 09/14/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31078
-
Benjamin Franzke uploaded patch set 3 09/14/22, 12:10
-
core-ci voted on patch set 3 V -1 09/14/22, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31082
-
Andreas Kienast uploaded patch set 4 09/14/22, 13:07
-
core-ci voted on patch set 4 V -1 09/14/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31084
-
Andreas Kienast uploaded patch set 5 09/14/22, 13:44
-
core-ci voted on patch set 5 V -1 09/14/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31085
-
Simon Schaufelberger commented on patch set 5 09/14/22, 21:25
wow, this is really cool! The currently hovered item has the wrong z-index as it overlaps the input field but my first impression is: awesome! -
Simon Schaufelberger commented on patch set 5 09/14/22, 21:30
Please also make sure the application information panel has no horizontal scrollbar which is the case for me. -
Andreas Kienast commented on patch set 5 09/15/22, 06:42
Reply
That's strange, I cannot reproduce that. There is an issue with the bookmarks menu that triggers a horizontal scrollbar for the whole document if it gets too wide, tho.Reply
Thanks for testing. I'm already aware of that issue, I'll check again once the missing features were added and tests are green again. -
Andreas Kienast uploaded patch set 6 09/15/22, 09:58
-
Andreas Kienast uploaded patch set 7 09/15/22, 09:59
-
core-ci voted on patch set 6 V +1 09/15/22, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31105
-
Andreas Kienast uploaded patch set 8 09/15/22, 10:12
-
Andreas Kienast uploaded patch set 9 09/15/22, 10:14
-
core-ci voted on patch set 7 V +1 09/15/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31106
-
core-ci voted on patch set 9 V +1 09/15/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31110
-
core-ci voted on patch set 8 V +1 09/15/22, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31108
-
Simon Schaufelberger voted on patch set 9 V +1 CR +1 09/15/22, 12:46
-
Andreas Kienast commented on patch set 9 CR -1 09/15/22, 13:54
working on something, will lift -1 soon -
Andreas Kienast uploaded patch set 10 09/15/22, 14:19
-
Simon Schaufelberger voted on patch set 10 V +1 CR +1 09/15/22, 14:27
-
core-ci voted on patch set 10 V -1 09/15/22, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31120
-
Andreas Kienast uploaded patch set 11 09/15/22, 14:45
-
Andreas Kienast uploaded patch set 12 09/15/22, 14:53
-
core-ci voted on patch set 11 V +1 09/15/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31121
-
core-ci voted on patch set 12 V +1 09/15/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31122
-
Andreas Kienast uploaded patch set 13 09/15/22, 17:21
-
core-ci voted on patch set 13 V +1 09/15/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31123
-
Simon Schaufelberger voted on patch set 13 V +1 CR +1 09/15/22, 17:45
-
Simon Schaufelberger commented on patch set 13 V -1 09/15/22, 18:15
I tried to compile the js avain to verify it but this is how the hints array looks when I output it in the console: 0: "#page:Home will search for all pages with the title \"Home\"" 1: undefined 2: undefined -
Simon Schaufelberger commented on patch set 13 V +1 09/15/22, 18:19
Reply
oh, forgot to clear the cache ;) -
Andreas Kienast uploaded patch set 14 09/16/22, 06:57
-
core-ci voted on patch set 14 V +1 09/16/22, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31145
-
Andreas Kienast commented on patch set 14 CR -1 09/16/22, 07:40
Benji makes things nicer -
Benjamin Kott uploaded patch set 15 09/16/22, 08:42
-
core-ci voted on patch set 15 V +1 09/16/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31153
-
Andreas Kienast commented on patch set 15 CR -2 09/16/22, 08:59
Benji and I are still working on it -
Andreas Kienast uploaded patch set 16 09/16/22, 09:02
-
core-ci voted on patch set 16 V +1 09/16/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31157
-
Benjamin Kott uploaded patch set 17 09/16/22, 10:49
-
Andreas Kienast voted on patch set 17 CR 0 09/16/22, 10:50
-
Benjamin Kott uploaded patch set 18 09/16/22, 10:51
-
Andreas Kienast uploaded patch set 19 09/16/22, 11:02
-
core-ci voted on patch set 17 V +1 09/16/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31169
-
core-ci voted on patch set 18 V +1 09/16/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31171
-
core-ci voted on patch set 19 V +1 09/16/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31174
-
Simon Schaufelberger commented on patch set 19 09/16/22, 11:22
Clicking on the bookmark icon adds a scrollbar now because the width to the right is slightly bigger than when closed. -
Simon Schaufelberger commented on patch set 19 09/16/22, 11:24
Reply
my user nams is simply "Admin" -
Andreas Kienast commented on patch set 19 09/16/22, 11:29
Reply
Can confirm. Bootstrap should take care of this, IIRC. Looks like an off-by-one issue. -
Andreas Kienast uploaded patch set 20 09/16/22, 11:33
-
core-ci voted on patch set 20 V +1 09/16/22, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31179
-
Simon Schaufelberger commented on patch set 20 09/16/22, 11:44
how about selecting the whole query input when opening the modal again? This is also what phpstorm is doing to be able to enter a different search term without deleting the previously entered search term. -
Andreas Kienast commented on patch set 20 09/16/22, 11:56
Reply
Ack. Is added with the next push. -
Andreas Kienast uploaded patch set 21 09/16/22, 12:03
-
Simon Schaufelberger voted on patch set 21 V +1 CR +1 09/16/22, 12:11
-
core-ci voted on patch set 21 V +1 09/16/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31186
-
Benjamin Kott voted on patch set 21 V +1 CR +1 09/16/22, 12:18
-
Andreas Kienast uploaded patch set 22 09/16/22, 12:25
-
Andreas Kienast commented on patch set 22 09/16/22, 12:25
rebased only -
Benjamin Kott voted on patch set 22 V +1 CR +1 09/16/22, 12:30
-
core-ci voted on patch set 22 V +1 09/16/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31190
-
Simon Schaufelberger voted on patch set 22 V +1 CR +1 09/16/22, 12:43
-
Jonas Eberle voted on patch set 22 V +1 09/16/22, 13:18
-
Benni Mack commented on patch set 22 V +1 CR +1 09/16/22, 15:18
Although I don't like the sliding down of the modal, I think we can move forward here. In general, I'll be working on a "Rich Snippet Result" concept to further improve the results. -
Andreas Kienast voted on patch set 22 V +2 CR +2 09/16/22, 15:34
-
Andreas Kienast merged patch set 23 09/16/22, 15:34