Review main Merged

75729[TASK] Remove superfluous jQuery UI theme in ext:viewpage

Torben Hansen CR +2 V +2 Hard +0 −559 updated 09/16/22, 10:48

Commit message

In ext:viewpage, jQuery UI resizable is used to allow an editor
to resize the iframe with the page preview. The fluid template
includes a customized jQuery UI theme, which is superfluous and
can be removed, since CSS classes required by the
jquery-ui-resizable component have been added to backend.css
with #90437

This change removed the custom jQuery UI theme from ext:viewpage.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 69

  1. Torben Hansen uploaded patch set 1 09/14/22, 09:00

  2. Torben Hansen updated the commit message in patch set 2 09/14/22, 09:01

  3. core-ci voted on patch set 1 V +1 09/14/22, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31074

  4. core-ci voted on patch set 2 V +1 09/14/22, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31075

  5. Christian Kuhn updated the commit message in patch set 3 09/16/22, 10:40

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 09/16/22, 10:40

  7. Andreas Kienast voted on patch set 3 V +2 CR +2 09/16/22, 10:47

  8. core-ci voted on patch set 3 V +1 09/16/22, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31167

  9. Andreas Kienast merged patch set 4 09/16/22, 10:48