Review main Merged

75731[TASK] Allow flushing the makeInstance class name caches for testing

Oliver Klee CR +2 V +2 Easy +5 −2 updated 09/16/22, 11:34

Commit message

`GeneralUtility::flushInternalRuntimeCaches` now also flushes the caches
used by `makeInstance` to determine the final class name for
instantiating classes. This allows unit tests to test that classes can
be XCLASSed without the dummy XCLASS configuration spilling over into
the next unit test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oliver Klee uploaded patch set 1 09/14/22, 10:30

  2. Oliver Klee updated the commit message in patch set 2 09/14/22, 10:31

  3. Oliver Klee updated the commit message in patch set 3 09/14/22, 10:31

  4. core-ci voted on patch set 3 V +1 09/14/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31081

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 09/16/22, 08:20

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 09/16/22, 11:33

  7. Christian Kuhn voted on patch set 3 V +2 CR +2 09/16/22, 11:34

  8. Christian Kuhn merged patch set 4 09/16/22, 11:34