Review main Merged

75733[BUGFIX] Allow injection of RenderingContextFactory

Susi Moog CR +2 V +2 Easy +2 −2 updated 09/15/22, 21:20

Commit message

This change allows the injection of the fluid
RenderingContextFactory while disallowing the
direct injection of the RenderingContext.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Susi Moog uploaded patch set 1 09/15/22, 12:17

  2. core-ci voted on patch set 1 V +1 09/15/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31115

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 09/15/22, 13:09

  4. Christian Kuhn updated the commit message in patch set 2 09/15/22, 13:10

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/15/22, 13:10

  6. core-ci voted on patch set 2 V +1 09/15/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31116

  7. Oliver Hader voted on patch set 2 CR +1 09/15/22, 13:37

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/15/22, 21:19

  9. Benjamin Franzke wrote 09/15/22, 21:19

    Topic set to di
  10. Benjamin Franzke merged patch set 3 09/15/22, 21:20