Review main Merged

75734[BUGFIX] Fix hide/unhide inline control for a special case

Nikita Hovratov CR +2 V +2 Easy +28 −3 updated 09/16/22, 12:28

Commit message

In case an inline field doesn't define the "disabled" column
in its "showitem" list, a hidden checkbox is now rendered in
the expanded state. This is the same checkbox, which is
rendered, when the inline item is initially visited in the
collapsed state.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Nikita Hovratov uploaded patch set 1 09/15/22, 19:09

  2. core-ci voted on patch set 1 V -1 09/15/22, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31124

  3. Nikita Hovratov uploaded patch set 2 09/15/22, 19:43

  4. core-ci voted on patch set 2 V -1 09/15/22, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31127

  5. Nikita Hovratov uploaded patch set 3 09/15/22, 20:18

  6. core-ci voted on patch set 3 V +1 09/15/22, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31130

  7. Nikita Hovratov uploaded patch set 4 09/15/22, 21:22

  8. Nikita Hovratov commented on patch set 4 09/15/22, 21:32

    Inline1nCest.php:124

    this change is needed, because the saving of the element changes the sorting of the first inline_1 child and will affect the sorting of next added inline_1 child.
  9. core-ci voted on patch set 4 V -1 09/15/22, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31133

  10. Nikita Hovratov uploaded patch set 5 09/15/22, 21:46

  11. core-ci voted on patch set 5 V +1 09/15/22, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31135

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 09/16/22, 12:24

  13. Stefan Bürk voted on patch set 5 V +2 CR +2 09/16/22, 12:28

  14. Stefan Bürk merged patch set 6 09/16/22, 12:28