Review main Merged

75735[BUGFIX] Rename modal's title property to modalTitle

Andreas Kienast CR +2 V +2 Easy +8 −8 updated 09/16/22, 09:12

Commit message

In #98288 the modal component was rewritten to be a lit element. The
modal title was defined by a `title` attribute. However, using this
attribute has the side effect that a tooltip is rendered wherever the
cursor is positioned.

Unfortunately, this behavior cannot get disabled in browsers. To
circumvent this issue, the attribute is now renamed to `modalTitle`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/16/22, 06:51

  2. core-ci voted on patch set 1 V +1 09/16/22, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31143

  3. Oliver Klee voted on patch set 1 CR +1 09/16/22, 08:20

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 09/16/22, 08:31

  5. Benni Mack voted on patch set 1 V +2 CR +2 09/16/22, 09:12

  6. Benni Mack merged patch set 2 09/16/22, 09:12