Review main Merged

75736[TASK] Simplify BackendUserGroupRepository::findByUidList

Oliver Hader CR +2 V +2 Easy +5 −16 updated 09/16/22, 10:56

Commit message

Instead of creating new database queries for each user group,
corresponding items are fetched in just one query.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 09/16/22, 07:34

  2. core-ci voted on patch set 1 V +1 09/16/22, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31149

  3. Oliver Klee voted on patch set 1 CR +1 09/16/22, 08:19

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 09/16/22, 08:24

  5. Benni Mack voted on patch set 1 CR +2 09/16/22, 09:01

  6. Benni Mack voted on patch set 1 V +1 09/16/22, 10:51

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 09/16/22, 10:56

  8. Christian Kuhn merged patch set 2 09/16/22, 10:56