75737[TASK] Revamp Constant Editor
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 53
- Build/phpstan/phpstan-baseline.neon+0 −5
- Build/Sources/TypeScript/tstemplate/constant-editor.ts+1 −21
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php+25 −0
- typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php+18 −0
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstConstantCommentVisitor.phpnew+501 −0
- typo3/sysext/core/Classes/TypoScript/AST/AbstractAstBuilder.phpnew+246 −0
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilder.php+4 −213
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilderInterface.phpnew+39 −0
- typo3/sysext/core/Classes/TypoScript/AST/CommentAwareAstBuilder.phpnew+175 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeAstBuilderVisitor.php+5 −2
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.phpdeleted+0 −328
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineStream.php+34 −0
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.phpdeleted+0 −612
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.phpdeleted+0 −311
- typo3/sysext/core/Classes/ServiceProvider.php+20 −6
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+1 −19
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderInterfaceTest.phpnew+120 −0
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderTest.phpdeleted+0 −72
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.phprenamed+738 −162
Show 33 more files
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/ConstantConfigurationParserTest.phpdeleted+0 −131
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+55 −7
- typo3/sysext/install/Classes/Controller/SettingsController.php+48 −26
- typo3/sysext/install/Classes/Service/ExtensionConfigurationService.phpdeleted+0 −84
- typo3/sysext/install/Classes/ServiceProvider.php+7 −12
- typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html+118 −23
- typo3/sysext/t3editor/Classes/Controller/CodeCompletionController.php+3 −6
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+53 −34
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+355 −339
- typo3/sysext/tstemplate/Classes/Controller/InfoModifyController.php+59 −48
- typo3/sysext/tstemplate/Classes/Controller/ObjectBrowserController.php+9 −2
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+0 −1
- typo3/sysext/tstemplate/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeCommentAwareAstBuilderVisitor.phpnew+86 −0
- typo3/sysext/tstemplate/Configuration/Backend/Modules.php+4 −3
- typo3/sysext/tstemplate/Configuration/Services.yaml+9 −0
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_ceditor.xlf+9 −3
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_objbrowser.xlf+3 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/ConstantEditorFields.htmlnew+203 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/ConstantEditorForm.htmldeleted+0 −81
- typo3/sysext/tstemplate/Resources/Private/Partials/ConstantEditorOptions.htmlnew+86 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/NoTemplate.html+58 −66
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserOptions.html+19 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTree.html+16 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTreePanel.html+2 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditor.htmldeleted+0 −21
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorMain.htmlnew+70 −0
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorNoTemplate.htmlnew+22 −0
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModify.htmldeleted+0 −21
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyMain.htmlrenamed+38 −32
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyNoTemplate.htmlnew+22 −0
- typo3/sysext/tstemplate/Resources/Private/Templates/ObjectBrowserMain.html+32 −29
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateRecordsOverview.html+2 −2
- typo3/sysext/tstemplate/Resources/Public/JavaScript/constant-editor.js+1 −1
Review log 1318
-
Christian Kuhn uploaded patch set 1 09/16/22, 08:55
-
Christian Kuhn voted on patch set 1 CR -1 09/16/22, 09:02
-
core-ci voted on patch set 1 V +1 09/16/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31155
-
Christian Kuhn uploaded patch set 2 09/16/22, 09:28
-
Christian Kuhn voted on patch set 2 CR -1 09/16/22, 09:28
-
core-ci voted on patch set 2 V -1 09/16/22, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31158
-
Christian Kuhn uploaded patch set 3 09/16/22, 10:04
-
Christian Kuhn updated the commit message in patch set 4 09/16/22, 10:07
-
core-ci voted on patch set 3 V +1 09/16/22, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31163
-
core-ci voted on patch set 4 V +1 09/16/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31164
-
Christian Kuhn rebased onto patch set 5 09/16/22, 10:17
-
core-ci voted on patch set 5 V +1 09/16/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31166
-
Benni Mack voted on patch set 5 CR +1 09/16/22, 14:33
-
Benni Mack voted on patch set 5 V +1 09/16/22, 15:12
-
Stefan Bürk commented on patch set 5 CR +1 09/16/22, 18:41
l -
Stefan Bürk voted on patch set 5 V +1 09/16/22, 18:49
-
Christian Kuhn voted on patch set 5 V +2 CR +2 09/16/22, 19:12
-
Christian Kuhn merged patch set 6 09/16/22, 19:12