Review main Merged

75740[BUGFIX] Darken progress bar for default and light panel

Oli Bartsch CR +2 V +2 Easy +11 −7 updated 09/21/22, 10:30

Commit message

To have the progress bar visible on a panels using the
"default" or "light" theme variant, the progress bar
color is now darkened for those variants.

Additionally, an unused "t3js" class is removed again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 913

  1. Oli Bartsch uploaded patch set 1 09/16/22, 09:46

  2. core-ci voted on patch set 1 V -1 09/16/22, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31161

  3. core-ci voted on patch set 1 V +1 09/16/22, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31161

  4. Benjamin Kott commented on patch set 1 CR -1 09/16/22, 11:09

    _panel.scss:298

    this is invalid, a defult variant is already generated.
  5. Oli Bartsch uploaded patch set 2 09/16/22, 13:52

  6. Oli Bartsch commented on patch set 2 09/16/22, 13:53

    _panel.scss:298 Reply

    Done as discussed.
  7. core-ci voted on patch set 2 V +1 09/16/22, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31194

  8. Oli Bartsch uploaded patch set 3 09/19/22, 07:23

  9. core-ci voted on patch set 3 V +1 09/19/22, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31258

  10. Frank Nägler voted on patch set 3 V +1 CR +1 09/20/22, 13:50

  11. Benni Mack voted on patch set 3 V +1 CR +1 09/21/22, 09:58

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 09/21/22, 10:30

  13. Oli Bartsch merged patch set 4 09/21/22, 10:30