Review main Merged

75746[BUGFIX] Guard array key access in TypoScriptFrontendController

Stefan Bürk CR +2 V +2 Easy +6 −3 updated 09/18/22, 07:15

Commit message

This change ensure guarded array key access to avoid corresponding
native PHP undefined array key access warnings in `getPageAndRootline`
of class `\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController`.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Stefan Bürk uploaded patch set 1 09/17/22, 14:57

  2. Stefan Bürk updated the commit message in patch set 2 09/17/22, 15:00

  3. Stefan Bürk updated the commit message in patch set 3 09/17/22, 15:00

  4. core-ci voted on patch set 2 V +1 09/17/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31205

  5. core-ci voted on patch set 3 V +1 09/17/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31206

  6. core-ci voted on patch set 1 V +1 09/17/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31204

  7. Oliver Klee voted on patch set 3 CR +1 09/17/22, 15:24

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 09/17/22, 15:56

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 09/18/22, 07:15

  10. Anja Leichsenring merged patch set 4 09/18/22, 07:15