75749[!!!][TASK] Cleanup and harden Extbase Request
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Lina Wolf +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Lina Wolf +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 32
- Build/phpstan/phpstan-baseline.neon+0 −180
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98370-ExtbaseRequestCleanupAndHardening.rst4new+75 −0
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+5 −5
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+4 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+4 −8
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+1 −7
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+10 −16
- typo3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php+24 −34
- typo3/sysext/extbase/Classes/Mvc/Request.php+8 −153
- typo3/sysext/extbase/Classes/Mvc/RequestInterface.php+24 −67
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+6 −6
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+9 −9
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+6 −6
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+15 −15
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+16 −11
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php+31 −69
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+2 −2
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php3+26 −10
Show 12 more files
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+2 −2
- typo3/sysext/fluid/Classes/View/StandaloneView.php2+8 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+10 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+4 −1
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+1 −3
- typo3/sysext/form/Classes/Controller/FormEditorController.php+2 −2
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+2 −4
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+2 −4
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+20 −9
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php2+30 −21
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+50 −14
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −5
Review log 3253
Show 1428 earlier messages
-
Christian Kuhn uploaded patch set 1 09/17/22, 17:53
-
core-ci voted on patch set 1 V -1 09/17/22, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31212
-
Christian Kuhn uploaded patch set 2 09/17/22, 19:09
-
core-ci voted on patch set 2 V +1 09/17/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31214
-
Christian Kuhn uploaded patch set 3 09/17/22, 19:25
-
core-ci voted on patch set 3 V +1 09/17/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31215
-
Christian Kuhn uploaded patch set 4 09/18/22, 09:28
-
core-ci voted on patch set 4 V +1 09/18/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31224
-
Christian Kuhn uploaded patch set 5 09/18/22, 09:41
-
core-ci voted on patch set 5 V -1 09/18/22, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31225
-
Christian Kuhn uploaded patch set 6 09/18/22, 09:51
-
core-ci voted on patch set 6 V -1 09/18/22, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31226
-
Christian Kuhn uploaded patch set 7 09/18/22, 10:06
-
core-ci voted on patch set 7 V +1 09/18/22, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31227
-
Christian Kuhn uploaded patch set 8 09/18/22, 10:33
-
core-ci voted on patch set 8 V -1 09/18/22, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31228
-
Christian Kuhn uploaded patch set 9 09/18/22, 12:14
-
core-ci voted on patch set 9 V +1 09/18/22, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31233
-
Christian Kuhn uploaded patch set 10 09/18/22, 12:55
-
core-ci voted on patch set 10 V +1 09/18/22, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31234
-
Christian Kuhn uploaded patch set 11 09/18/22, 13:06
-
core-ci voted on patch set 11 V +1 09/18/22, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31235
-
Christian Kuhn uploaded patch set 12 09/18/22, 13:14
-
core-ci voted on patch set 12 V +1 09/18/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31236
-
Christian Kuhn uploaded patch set 13 09/18/22, 13:30
-
core-ci voted on patch set 13 V +1 09/18/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31237
-
Christian Kuhn uploaded patch set 14 09/18/22, 13:55
-
core-ci voted on patch set 14 V +1 09/18/22, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31238
-
Lina Wolf commented on patch set 14 09/18/22, 14:41
Happy that you are working on this, I will sit back and watch 😎 -
Christian Kuhn uploaded patch set 15 09/18/22, 14:41
-
core-ci voted on patch set 15 V -1 09/18/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31239
-
Christian Kuhn uploaded patch set 16 09/18/22, 14:49
-
Christian Kuhn updated the commit message in patch set 17 09/18/22, 14:57
-
core-ci voted on patch set 16 V +1 09/18/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31240
-
Christian Kuhn voted on patch set 17 CR -1 09/18/22, 14:58
-
core-ci voted on patch set 17 V +1 09/18/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31241
-
Christian Kuhn uploaded patch set 18 09/18/22, 15:50
-
core-ci voted on patch set 18 V +1 09/18/22, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31242
-
Christian Kuhn uploaded patch set 19 09/18/22, 16:00
-
Lina Wolf commented on patch set 19 09/18/22, 16:02
Breaking-98370-ExtbaseRequestCleanupAndHardening.rst:73Is it not possible to scan for usage of these setXY methods? -
Christian Kuhn uploaded patch set 20 09/18/22, 16:03
-
Christian Kuhn commented on patch set 19 09/18/22, 16:06
Breaking-98370-ExtbaseRequestCleanupAndHardening.rst:73Replyyes and no: There are *some* methods that are kinda specific, but things like "setFormat()" are quite generic and would lead to lots of false positives with the extension scanner. I think a tool like phpstan established for extbase extensions is better suited here, so I decided to not add scanner entries for the 'setter' methods that have been removed. -
core-ci voted on patch set 19 V +1 09/18/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31244
-
core-ci voted on patch set 20 V +1 09/18/22, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31245
-
Lina Wolf commented on patch set 20 CR +1 09/18/22, 16:20
Code looks good to me as far as I can tell. Testing now. -
Stefan Bürk commented on patch set 20 09/18/22, 16:45
Breaking-98370-ExtbaseRequestCleanupAndHardening.rst:14Don't we normally write php full quallified namespaces classes (fqnc) with leading backslash, or am I wrong ? (If yes, more occurances in this file.)PasswordRecoveryController.php:99Should we not add that attribute at least to the PHPStorm meta file, avoiding the need for variable docblock ? Edit: arg .. we need to extend the phpstan extension to to make phpstan happy then.StandaloneView.php:56Missing $request = assigment ? ``` $request = $request->withFormat($format); ```FluidTemplateContentObject.php:272Request no imutable - retrieved in L231 into local variable from $this->request. It is eventually changed, but not reassigned to $this->request ... missing or intended to reasign changed $request not only to view but to class property also ? -
Christian Kuhn commented on patch set 20 09/18/22, 16:58
Breaking-98370-ExtbaseRequestCleanupAndHardening.rst:14Replyunsure. can add the here to be more precise.PasswordRecoveryController.php:99Replyyeah. we'd need a mapping then. left out for now, might be a dedicated task if we wish to solve this.StandaloneView.php:56Replythx. good catch.FluidTemplateContentObject.php:272Replythx. good catch. -
Christian Kuhn uploaded patch set 21 09/18/22, 16:58
-
Lina Wolf commented on patch set 21 V +1 CR +1 09/18/22, 17:06
Tested with fe_login, forms, (as provided by styleguide), friendsoftypo3/blog-example:dev-12.0-dev and ttn/tea:dev-lwolf-v12-compability Behaviour before and after change is the same as far as I can tell. -
core-ci voted on patch set 21 V +1 09/18/22, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31246
-
Stefan Bürk commented on patch set 21 V +1 CR +1 09/18/22, 17:45
PasswordRecoveryController.php:99Replyack to dedicated task. -
Christian Kuhn voted on patch set 21 V +2 CR +2 09/18/22, 17:51
-
Christian Kuhn merged patch set 22 09/18/22, 17:51