Review main Merged

75772[TASK] Remove _DEFAULT_PI_VARS from TypoScript

Lina Wolf CR +2 V +2 Easy +8 −8 updated 09/18/22, 14:28

Commit message

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/75655 the `AbstractPlugin` was made internal.

Option `_DEFAULT_PI_VARS` was only used in the `AbstractPlugin` and can therefore be removed from the TypoScript API.

Additionally `_LOCAL_LANG.[lang-key].[label-key]` now only works for Extbase plugins, the description needs to be adjusted.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Chris Müller +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 812

  1. Lina Wolf uploaded patch set 1 09/18/22, 11:03

  2. Lina Wolf commented on patch set 2 09/18/22, 11:08

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 09/18/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31229

  4. core-ci voted on patch set 2 V +1 09/18/22, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31230

  5. Lina Wolf commented on patch set 3 09/18/22, 11:26

    Published edit on patch set 2.
  6. Lina Wolf updated the commit message in patch set 4 09/18/22, 11:27

  7. Chris Müller voted on patch set 4 CR +1 09/18/22, 11:31

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 09/18/22, 11:35

  9. core-ci voted on patch set 4 V +1 09/18/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31232

  10. core-ci voted on patch set 3 V -1 09/18/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31231

  11. Lina Wolf voted on patch set 4 V +2 CR +2 09/18/22, 14:28

  12. Lina Wolf merged patch set 5 09/18/22, 14:28