Review main Abandoned

75774[WIP][FEATURE] Add PSR-14 events for rendering content previews

Benni Mack CR 0 V 0 Expert +835 −304 updated 03/24/23, 11:44

Commit message

This change unifies the rendering of preview
elements for content elements within the Page Module.

Currently done:
* Migrate all existing PreviewRenderers to PSR-14 Event Listeners
  and also incorporate a new FluidPreviewRenderer and a
  FallbackPreviewRenderer.
* Continue to allow "StandardPreviewRendererResolver" and
  "StandardPreviewRenderer" as a fallback to still be
  used.

Next up:
* Add Deprecations (also to the usages when StandardPreviewRendererResolver
  is used)
* Split up the RecordPreviewEvent in one for the page module
  and a more generic one.
* Add proper tests for the now standalone PreviewRenderers
* Write enough RSTs
* See if we can get rid of RecordPreviewEvent->getGridColumnItem()

Review

  • Code review CR 0
  • Verified V 0

Files 21

Show 1 more file

Review log 610

  1. Benni Mack uploaded patch set 1 09/19/22, 08:23

  2. core-ci voted on patch set 1 V +1 09/19/22, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31259

  3. Benni Mack uploaded patch set 2 09/19/22, 11:18

  4. core-ci voted on patch set 2 V -1 09/19/22, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31264

  5. Oliver Hader commented on patch set 2 09/19/22, 13:42

    ext_localconf.php:31 Unresolved

    +1 :D
  6. Benni Mack uploaded patch set 3 09/20/22, 06:54

  7. core-ci voted on patch set 3 V +1 09/20/22, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31305

  8. Benni Mack updated the commit message in patch set 4 09/22/22, 23:05

  9. core-ci voted on patch set 4 V +1 09/22/22, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31467

  10. Benni Mack abandoned the change 03/24/23, 11:44