Review main Merged Breaking

75778[!!!][FEATURE] Add PSR-14 Events for customized Page Module rendering

Benni Mack CR +2 V +2 Nightmare +348 −2236 updated 09/19/22, 17:48

Commit message

The three legacy hooks
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['record_is_used']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][PageLayoutView::class]['modifyQuery']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawItem']

are replaced by new PSR-14 Events:

* TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent
* TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent
* TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent

Additionally, the hooks
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['list_type_Info']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawFooter']
are removed as the same functionality can be achieved
with the existing PreviewRenderer functionality since TYPO3 v10.

The previous "main class" PageLayoutView is now removed (was marked
as internal) along with the interfaces for the removed hooks

* TYPO3\CMS\Backend\View\PageLayoutViewDrawFooterHookInterface
* TYPO3\CMS\Backend\View\PageLayoutViewDrawItemHookInterface

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 912

  1. Benni Mack uploaded patch set 1 09/19/22, 14:37

  2. core-ci voted on patch set 1 V -1 09/19/22, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31274

  3. Benni Mack uploaded patch set 2 09/19/22, 14:54

  4. core-ci voted on patch set 2 V -1 09/19/22, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31276

  5. Benni Mack uploaded patch set 3 09/19/22, 15:16

  6. core-ci voted on patch set 3 V +1 09/19/22, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31279

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 09/19/22, 15:32

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/19/22, 16:37

  9. Stefan Bürk voted on patch set 3 CR +1 09/19/22, 16:52

  10. Stefan Bürk voted on patch set 3 V +1 09/19/22, 17:03

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 09/19/22, 17:48

  12. Christian Kuhn merged patch set 4 09/19/22, 17:48