75781[TASK] Deprecate support for RequireJS modules
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
Issues 3
Files 12
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php2+4 −1
- typo3/sysext/core/Classes/Controller/RequireJsController.php+2 −0
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+9 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+6 −2
- typo3/sysext/core/Configuration/Backend/AjaxRoutes.php+1 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97057-DeprecateRequireJSSupport.rst4new+75 −0
- typo3/sysext/core/Tests/Functional/Page/JavaScriptRendererTest.php+3 −3
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+4 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+5 −15
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+5 −1
- typo3/sysext/setup/Classes/Event/AddJavaScriptModulesEvent.php+28 −0
Review log 2839
Show 814 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/19/22, 18:48
-
core-ci voted on patch set 1 V -1 09/19/22, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31289
-
Benjamin Franzke uploaded patch set 2 09/22/22, 13:19
-
core-ci voted on patch set 2 V +1 09/22/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31446
-
Benjamin Franzke rebased onto patch set 3 09/22/22, 14:09
-
core-ci voted on patch set 3 V +1 09/22/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31455
-
Benjamin Franzke rebased onto patch set 4 09/22/22, 15:55
-
core-ci voted on patch set 4 V +1 09/22/22, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31459
-
Benjamin Franzke uploaded patch set 5 10/01/22, 19:49
-
Georg Ringer voted on patch set 5 V +1 CR +1 10/01/22, 19:58
-
core-ci voted on patch set 5 V -1 10/01/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31844
-
Benjamin Franzke uploaded patch set 6 10/01/22, 20:09
-
Benjamin Franzke rebased onto patch set 7 10/01/22, 20:17
-
core-ci voted on patch set 6 V -1 10/01/22, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31846
-
core-ci voted on patch set 7 V -1 10/01/22, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31848
-
Benjamin Franzke uploaded patch set 8 10/01/22, 20:41
-
core-ci voted on patch set 8 V +1 10/01/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31850
-
Benni Mack commented on patch set 8 10/01/22, 21:37
-
Benjamin Franzke uploaded patch set 9 10/01/22, 21:48
-
Benjamin Franzke commented on patch set 9 10/01/22, 21:48
AbstractFormElement.php:340ReplyDone (the entire block will vanish, as `shallLoadRequireJs()` will be removed as will. Added comments to both. -
core-ci voted on patch set 9 V +1 10/01/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31851
-
Chris Müller commented on patch set 9 10/02/22, 06:14
Deprecation-97057-DeprecateRequireJSSupport.rst:14[1] is not mentioned again. Please use a link to the according resource. -
Benjamin Franzke rebased onto patch set 10 10/02/22, 18:32
-
Benjamin Franzke uploaded patch set 11 10/02/22, 18:35
-
Benjamin Franzke commented on patch set 11 10/02/22, 18:35
Deprecation-97057-DeprecateRequireJSSupport.rst:14ReplyDone -
core-ci voted on patch set 11 V +1 10/02/22, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31905
-
Benni Mack voted on patch set 11 CR +1 10/02/22, 18:59
-
Georg Ringer voted on patch set 11 V +1 CR +1 10/03/22, 06:06
-
Kevin Appelt voted on patch set 11 CR +1 10/03/22, 06:29
-
Benjamin Franzke wrote 10/03/22, 10:30
Topic set to esm -
Nikita Hovratov commented on patch set 11 10/03/22, 18:04
Deprecation-97057-DeprecateRequireJSSupport.rst:24Seems like a type is missing here. -
Christian Kuhn uploaded patch set 12 10/03/22, 18:44
-
Christian Kuhn commented on patch set 11 10/03/22, 18:44
Deprecation-97057-DeprecateRequireJSSupport.rst:24ReplyDone -
Christian Kuhn voted on patch set 12 V +1 CR +1 10/03/22, 18:44
-
Georg Ringer voted on patch set 12 V +1 CR +1 10/03/22, 18:50
-
Georg Ringer voted on patch set 12 V +2 CR +2 10/03/22, 18:50
-
Georg Ringer merged patch set 13 10/03/22, 18:50
-
Oliver Hader voted on patch set 13 CR +1 10/03/22, 18:58
-
core-ci voted on patch set 12 V +1 10/03/22, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31953
AbstractFormElement.php:340