Review main Merged

75781[TASK] Deprecate support for RequireJS modules

Benjamin Franzke CR +2 V +2 Normal +143 −26 updated 10/03/22, 19:05

Commit message

The RequireJS project has been discontinued [1] and was therefore
replaced by native ECMAScript v6/v11 modules in TYPO3 with #96510.

The infrastructure for configuration and loading of RequireJS
modules is now deprecated and will be removed in TYPO3 v13.

[1] https://github.com/requirejs/requirejs/issues/1816

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1

Issues 3

Files 12

Review log 2839

Show 814 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/19/22, 18:48

  2. core-ci voted on patch set 1 V -1 09/19/22, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31289

  3. Benjamin Franzke uploaded patch set 2 09/22/22, 13:19

  4. core-ci voted on patch set 2 V +1 09/22/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31446

  5. Benjamin Franzke rebased onto patch set 3 09/22/22, 14:09

  6. core-ci voted on patch set 3 V +1 09/22/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31455

  7. Benjamin Franzke rebased onto patch set 4 09/22/22, 15:55

  8. core-ci voted on patch set 4 V +1 09/22/22, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31459

  9. Benjamin Franzke uploaded patch set 5 10/01/22, 19:49

  10. Georg Ringer voted on patch set 5 V +1 CR +1 10/01/22, 19:58

  11. core-ci voted on patch set 5 V -1 10/01/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31844

  12. Benjamin Franzke uploaded patch set 6 10/01/22, 20:09

  13. Benjamin Franzke rebased onto patch set 7 10/01/22, 20:17

  14. core-ci voted on patch set 6 V -1 10/01/22, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31846

  1. core-ci voted on patch set 7 V -1 10/01/22, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31848

  2. Benjamin Franzke uploaded patch set 8 10/01/22, 20:41

  3. core-ci voted on patch set 8 V +1 10/01/22, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31850

  4. Benni Mack commented on patch set 8 10/01/22, 21:37

    AbstractFormElement.php:340

    can we add a @todo so we know we have to remove it in v13?
  5. Benjamin Franzke uploaded patch set 9 10/01/22, 21:48

  6. Benjamin Franzke commented on patch set 9 10/01/22, 21:48

    AbstractFormElement.php:340 Reply

    Done (the entire block will vanish, as `shallLoadRequireJs()` will be removed as will. Added comments to both.
  7. core-ci voted on patch set 9 V +1 10/01/22, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31851

  8. Chris Müller commented on patch set 9 10/02/22, 06:14

    Deprecation-97057-DeprecateRequireJSSupport.rst:14

    [1] is not mentioned again. Please use a link to the according resource.
  9. Benjamin Franzke rebased onto patch set 10 10/02/22, 18:32

  10. Benjamin Franzke uploaded patch set 11 10/02/22, 18:35

  11. Benjamin Franzke commented on patch set 11 10/02/22, 18:35

    Deprecation-97057-DeprecateRequireJSSupport.rst:14 Reply

    Done
  12. core-ci voted on patch set 11 V +1 10/02/22, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31905

  13. Benni Mack voted on patch set 11 CR +1 10/02/22, 18:59

  14. Georg Ringer voted on patch set 11 V +1 CR +1 10/03/22, 06:06

  15. Kevin Appelt voted on patch set 11 CR +1 10/03/22, 06:29

  16. Benjamin Franzke wrote 10/03/22, 10:30

    Topic set to esm
  17. Nikita Hovratov commented on patch set 11 10/03/22, 18:04

    Deprecation-97057-DeprecateRequireJSSupport.rst:24

    Seems like a type is missing here.
  18. Christian Kuhn uploaded patch set 12 10/03/22, 18:44

  19. Christian Kuhn commented on patch set 11 10/03/22, 18:44

    Deprecation-97057-DeprecateRequireJSSupport.rst:24 Reply

    Done
  20. Christian Kuhn voted on patch set 12 V +1 CR +1 10/03/22, 18:44

  21. Georg Ringer voted on patch set 12 V +1 CR +1 10/03/22, 18:50

  22. Georg Ringer voted on patch set 12 V +2 CR +2 10/03/22, 18:50

  23. Georg Ringer merged patch set 13 10/03/22, 18:50

  24. Oliver Hader voted on patch set 13 CR +1 10/03/22, 18:58

  25. core-ci voted on patch set 12 V +1 10/03/22, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31953