75782[!!!][TASK] Require ServerRequestInterface in Extbase Request
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 30
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98370-ExtbaseRequestCleanupAndHardening.rst+5 −0
- typo3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php2+1 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php+1 −26
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+3 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+4 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+8 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+5 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php+34 −31
- typo3/sysext/fluid/Classes/View/StandaloneView.php+7 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/Menus/ActionMenuItemViewHelperTest.php+4 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/Select/OptionViewHelperTest.php+20 −9
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CheckboxViewHelperTest.php+16 −8
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/HiddenViewHelperTest.php+4 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/PasswordViewHelperTest.php+8 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/RadioViewHelperTest.php+12 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+40 −20
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SubmitViewHelperTest.php+0 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/TextareaViewHelperTest.php+2 −1
Show 10 more files
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/TextfieldViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/UploadViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ResourceViewHelperTest.php+4 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FlashMessagesViewHelperTest.php+4 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+4 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/PageRendererViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+3 −1
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+4 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+5 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+4 −1
Review log 1319
-
Christian Kuhn uploaded patch set 1 09/19/22, 19:14
-
core-ci voted on patch set 1 V -1 09/19/22, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31293
-
Christian Kuhn uploaded patch set 2 09/19/22, 21:16
-
core-ci voted on patch set 2 V -1 09/19/22, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31295
-
Christian Kuhn uploaded patch set 3 09/21/22, 10:55
-
Christian Kuhn uploaded patch set 4 09/21/22, 10:57
-
core-ci voted on patch set 3 V -1 09/21/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31348
-
core-ci voted on patch set 4 V +1 09/21/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31349
-
Christian Kuhn uploaded patch set 5 09/21/22, 11:11
-
core-ci voted on patch set 5 V +1 09/21/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31350
-
Benjamin Franzke commented on patch set 5 09/21/22, 11:44
Imperative please. Maybe: Require ServerRequestInterface as dependency for extbase Request instantiation -
Christian Kuhn updated the commit message in patch set 6 09/21/22, 11:47
-
Christian Kuhn commented on patch set 5 09/21/22, 11:47
Reply
Done -
core-ci voted on patch set 6 V +1 09/21/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31353
-
Benni Mack commented on patch set 6 CR +1 09/21/22, 13:11
ExtbaseRequestParameters.php:219beautiful -
Benni Mack voted on patch set 6 V +1 09/21/22, 13:11
-
Christian Kuhn commented on patch set 6 09/21/22, 13:13
ExtbaseRequestParameters.php:219Replydrive-by ;) -
Benjamin Franzke voted on patch set 6 V +2 CR +2 09/21/22, 13:18
-
Benjamin Franzke merged patch set 7 09/21/22, 13:18