Review main Merged Breaking

75782[!!!][TASK] Require ServerRequestInterface in Extbase Request

Christian Kuhn CR +2 V +2 Hard +210 −139 updated 09/21/22, 13:18

Commit message

The Extbase Request still had a fallback to fetch
the base Request from $GLOBALS. The base Request
is of course a hard dependency of the Extbase
Request, it should be actively hand over as
construct argument.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 30

Show 10 more files

Review log 1319

  1. Christian Kuhn uploaded patch set 1 09/19/22, 19:14

  2. core-ci voted on patch set 1 V -1 09/19/22, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31293

  3. Christian Kuhn uploaded patch set 2 09/19/22, 21:16

  4. core-ci voted on patch set 2 V -1 09/19/22, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31295

  5. Christian Kuhn uploaded patch set 3 09/21/22, 10:55

  6. Christian Kuhn uploaded patch set 4 09/21/22, 10:57

  7. core-ci voted on patch set 3 V -1 09/21/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31348

  8. core-ci voted on patch set 4 V +1 09/21/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31349

  9. Christian Kuhn uploaded patch set 5 09/21/22, 11:11

  10. core-ci voted on patch set 5 V +1 09/21/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31350

  11. Benjamin Franzke commented on patch set 5 09/21/22, 11:44

    Imperative please. Maybe: Require ServerRequestInterface as dependency for extbase Request instantiation
  12. Christian Kuhn updated the commit message in patch set 6 09/21/22, 11:47

  13. Christian Kuhn commented on patch set 5 09/21/22, 11:47

    Reply

    Done
  14. core-ci voted on patch set 6 V +1 09/21/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31353

  15. Benni Mack commented on patch set 6 CR +1 09/21/22, 13:11

    ExtbaseRequestParameters.php:219

    beautiful
  16. Benni Mack voted on patch set 6 V +1 09/21/22, 13:11

  17. Christian Kuhn commented on patch set 6 09/21/22, 13:13

    ExtbaseRequestParameters.php:219 Reply

    drive-by ;)
  18. Benjamin Franzke voted on patch set 6 V +2 CR +2 09/21/22, 13:18

  19. Benjamin Franzke merged patch set 7 09/21/22, 13:18