Review main Merged

75783[TASK] Type hint ext:fluid RenderingContext

Christian Kuhn CR +2 V +2 Hard +115 −137 updated 09/20/22, 07:21

Commit message

The ext:fluid RenderingContext extends standalone fluid
RenderingContextInterface by adding getRequest(). This
object is always carried around in TYPO3 fluid universe.

When calling getRequest() in ViewHelpers, IDE's and
static analyzers don't know about this inheritance.
Unfortunately, we can't change standalone fluid at the
moment since that would be breaking, and we can't
change VH's method signatures either since that would
violate contravariance.

For now, we add a series on @var hints within various
ViewHelpers to make phpstan and IDE's more happy.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 911

  1. Christian Kuhn uploaded patch set 1 09/19/22, 20:31

  2. core-ci voted on patch set 1 V +1 09/19/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31294

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 09/19/22, 20:52

  4. Christian Kuhn uploaded patch set 2 09/20/22, 06:16

  5. Christian Kuhn commented on patch set 2 09/20/22, 06:17

    rebase due to phpstan baseline conflict only.
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 09/20/22, 06:19

  7. core-ci voted on patch set 2 V +1 09/20/22, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31304

  8. Benni Mack voted on patch set 2 V +1 CR +1 09/20/22, 06:47

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/20/22, 07:18

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/20/22, 07:21

  11. Anja Leichsenring merged patch set 3 09/20/22, 07:21