Review main Merged Breaking

75796[!!!][TASK] Enable internal subrequests for error pages

Benni Mack CR +2 V +2 Normal +7 −106 updated 09/21/22, 14:12

Commit message

With TYPO3 v11, a new feature flag "subrequestPageErrors"
was added to avoid external requests when loading error pages
such as the 404 page. This feature is now always enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 811

  1. Benni Mack uploaded patch set 1 09/20/22, 14:19

  2. Oliver Hader voted on patch set 1 CR +1 09/20/22, 14:26

  3. core-ci voted on patch set 1 V +1 09/20/22, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31322

  4. Christian Kuhn uploaded patch set 2 09/21/22, 13:53

  5. core-ci voted on patch set 2 V +1 09/21/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31374

  6. Andreas Kienast uploaded patch set 3 09/21/22, 14:03

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 09/21/22, 14:03

  8. core-ci voted on patch set 3 V +1 09/21/22, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31375

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 09/21/22, 14:11

  10. Benni Mack voted on patch set 3 V +2 CR +2 09/21/22, 14:12

  11. Benni Mack merged patch set 4 09/21/22, 14:12