Review main Merged

75799[BUGFIX] Update missing file properties

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 09/21/22, 13:02

Commit message

Do not expect all properties to already exist.
Update properties with different value as well as missing properties.

This check also prevents PHP 8.x warnings due to accessing unavailable
array keys.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Daniel Siepmann uploaded patch set 1 09/21/22, 07:09

  2. core-ci voted on patch set 1 V +1 09/21/22, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31337

  3. Oliver Klee voted on patch set 1 CR +1 09/21/22, 09:13

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 09/21/22, 12:47

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 09/21/22, 12:55

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 09/21/22, 13:02

  7. Christian Kuhn merged patch set 2 09/21/22, 13:02