Review main Merged

75802[BUGFIX] Don't ignore TCA 'ctrl' 'groupName'

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 09/22/22, 11:21

Commit message

The new records controller (list modul "+" button) tries
to group records. TCA 'ctrl' property 'groupName'
can be used to hint this grouping.

Current code overrides TCA groupName with split magic
based on table name, though. The patch fixes this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 09/21/22, 12:14

  2. Christian Kuhn updated the commit message in patch set 2 09/21/22, 12:16

  3. core-ci voted on patch set 1 V +1 09/21/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31359

  4. core-ci voted on patch set 2 V +1 09/21/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31360

  5. Simon Schaufelberger voted on patch set 2 V +1 CR +1 09/21/22, 12:30

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 09/21/22, 12:46

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/21/22, 12:47

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 09/21/22, 12:48

  9. Christian Kuhn merged patch set 3 09/21/22, 12:48

  10. Markus Klein commented on patch set 3 09/22/22, 11:21