Review main Merged

75808[TASK] Allow f:link.page and f:uri.page without Extbase

Benni Mack CR +2 V +2 Hard +663 −58 updated 09/29/22, 12:34

Commit message

This change uses the core UriBuilder and LinkFactory (FE)
for creating links in f:link.page and f:uri.page to avoid
booting up Extbase when using f:link.page in non-Extbase
Fluid context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1929

Show 34 earlier messages
  1. Benni Mack uploaded patch set 1 09/21/22, 14:48

  2. core-ci voted on patch set 1 V -1 09/21/22, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31380

  3. Simon Schaufelberger commented on patch set 1 09/21/22, 23:11

    in a

    PageViewHelper.php:114

    wouldn't it be better to check for "instance of ServerRequestInterface" here which the "fromRequest" method expects?

    PageViewHelper.php:225

    import namespace

    PageViewHelper.php:228

    import namespace
  4. Christian Kuhn commented on patch set 1 CR -1 09/28/22, 05:58

    working on it.
  1. Christian Kuhn commented on patch set 1 09/28/22, 06:09

    Reply

    no.

    Reply

    Done

    PageViewHelper.php:114 Reply

    Done

    PageViewHelper.php:225 Reply

    Done

    PageViewHelper.php:228 Reply

    Done
  2. Christian Kuhn uploaded patch set 2 09/28/22, 06:11

  3. Christian Kuhn voted on patch set 2 CR -1 09/28/22, 06:11

  4. core-ci voted on patch set 2 V +1 09/28/22, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31629

  5. Christian Kuhn uploaded patch set 3 09/28/22, 09:01

  6. Christian Kuhn voted on patch set 3 CR -1 09/28/22, 09:01

  7. core-ci voted on patch set 3 V -1 09/28/22, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31642

  8. Christian Kuhn rebased onto patch set 4 09/28/22, 09:55

  9. core-ci voted on patch set 4 V -1 09/28/22, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31644

  10. Christian Kuhn rebased onto patch set 5 09/29/22, 10:09

  11. core-ci voted on patch set 5 V +1 09/29/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31693

  12. Christian Kuhn rebased onto patch set 6 09/29/22, 10:28

  13. core-ci voted on patch set 6 V +1 09/29/22, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31698

  14. Christian Kuhn uploaded patch set 7 09/29/22, 11:24

  15. Christian Kuhn rebased onto patch set 8 09/29/22, 11:29

  16. core-ci voted on patch set 7 V +1 09/29/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31699

  17. core-ci voted on patch set 8 V +1 09/29/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31701

  18. Christian Kuhn uploaded patch set 9 09/29/22, 12:08

  19. core-ci voted on patch set 9 V +1 09/29/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31703

  20. Christian Kuhn uploaded patch set 10 09/29/22, 12:25

  21. Stefan Bürk voted on patch set 10 V +1 CR +1 09/29/22, 12:29

  22. Andreas Kienast voted on patch set 10 V +1 CR +1 09/29/22, 12:32

  23. core-ci voted on patch set 10 V +1 09/29/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31704

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 09/29/22, 12:34

  25. Christian Kuhn merged patch set 11 09/29/22, 12:34