75808[TASK] Allow f:link.page and f:uri.page without Extbase
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php6+144 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+130 −11
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+194 −18
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+194 −18
Review log 1929
Show 34 earlier messages
-
Benni Mack uploaded patch set 1 09/21/22, 14:48
-
core-ci voted on patch set 1 V -1 09/21/22, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31380
-
Simon Schaufelberger commented on patch set 1 09/21/22, 23:11
is this a little bit related to https://review.typo3.org/c/Packages/TYPO3.CMS/+/66322 ?in aPageViewHelper.php:114wouldn't it be better to check for "instance of ServerRequestInterface" here which the "fromRequest" method expects?PageViewHelper.php:225import namespacePageViewHelper.php:228import namespace -
Christian Kuhn commented on patch set 1 CR -1 09/28/22, 05:58
working on it.
-
Christian Kuhn commented on patch set 1 09/28/22, 06:09
Reply
no.Reply
DonePageViewHelper.php:114ReplyDonePageViewHelper.php:225ReplyDonePageViewHelper.php:228ReplyDone -
Christian Kuhn uploaded patch set 2 09/28/22, 06:11
-
Christian Kuhn voted on patch set 2 CR -1 09/28/22, 06:11
-
core-ci voted on patch set 2 V +1 09/28/22, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31629
-
Christian Kuhn uploaded patch set 3 09/28/22, 09:01
-
Christian Kuhn voted on patch set 3 CR -1 09/28/22, 09:01
-
core-ci voted on patch set 3 V -1 09/28/22, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31642
-
Christian Kuhn rebased onto patch set 4 09/28/22, 09:55
-
core-ci voted on patch set 4 V -1 09/28/22, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31644
-
Christian Kuhn rebased onto patch set 5 09/29/22, 10:09
-
core-ci voted on patch set 5 V +1 09/29/22, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31693
-
Christian Kuhn rebased onto patch set 6 09/29/22, 10:28
-
core-ci voted on patch set 6 V +1 09/29/22, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31698
-
Christian Kuhn uploaded patch set 7 09/29/22, 11:24
-
Christian Kuhn rebased onto patch set 8 09/29/22, 11:29
-
core-ci voted on patch set 7 V +1 09/29/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31699
-
core-ci voted on patch set 8 V +1 09/29/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31701
-
Christian Kuhn uploaded patch set 9 09/29/22, 12:08
-
core-ci voted on patch set 9 V +1 09/29/22, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31703
-
Christian Kuhn uploaded patch set 10 09/29/22, 12:25
-
Stefan Bürk voted on patch set 10 V +1 CR +1 09/29/22, 12:29
-
Andreas Kienast voted on patch set 10 V +1 CR +1 09/29/22, 12:32
-
core-ci voted on patch set 10 V +1 09/29/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31704
-
Christian Kuhn voted on patch set 10 V +2 CR +2 09/29/22, 12:34
-
Christian Kuhn merged patch set 11 09/29/22, 12:34