75836[TASK] Improve usability of logicalAnd and logicalOr
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 8
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php+2 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst+3 −61
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96107-DeprecatedFunctionalityRemoved.rst+4 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+34 −18
- typo3/sysext/extbase/Classes/Persistence/QueryInterface.php+6 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+1 −5
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php+4 −4
Review log 1317
-
Markus Klein uploaded patch set 1 09/22/22, 03:33
-
Markus Klein uploaded patch set 2 09/22/22, 03:39
-
core-ci voted on patch set 1 V -1 09/22/22, 03:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31407
-
core-ci voted on patch set 2 V -1 09/22/22, 03:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31408
-
Stephan Großberndt commented on patch set 2 09/22/22, 09:14
This change is ready for review. -
Stephan Großberndt commented on patch set 2 09/22/22, 09:15
Failure for PHP >= 8.1: Line beuser/Classes/Domain/Repository/BackendUserRepository.php ------ ----------------------------------------------------------------------- Ignored error pattern #^Method TYPO3\\CMS\\Extbase\\Persistence\\QueryInterface\:\:logicalAnd\(\) invoked with 1 parameter, at least 2 required\.$# in path /builds/typo3/CI/cms/typo3/sysext/beuser/Classes/Domain/Repository/Ba ckendUserRepository.php was not matched in reported errors. -
Markus Klein commented on patch set 2 CR -1 09/22/22, 10:04
Thanks Stephan, I had it on WIP since I did not create a ticket yet and I did not make CI happy yet. -
Markus Klein uploaded patch set 3 09/22/22, 11:43
-
core-ci voted on patch set 3 V -1 09/22/22, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31430
-
Markus Klein uploaded patch set 4 09/22/22, 12:17
-
core-ci voted on patch set 4 V +1 09/22/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31435
-
Stephan Großberndt commented on patch set 4 09/22/22, 13:06
Thanks for taking care, Markus. Setting the patch from WIP to "Ready for review" was not intentional. Although you advertised it in #typo3-coredev already ;) I think this is an important change making developers life on upgrade and for supporting older versions easier. -
Stephan Großberndt commented on patch set 4 09/22/22, 13:06
Reply
Done -
Benni Mack voted on patch set 4 V +1 CR +1 10/01/22, 10:15
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/01/22, 12:40
-
Stefan Bürk voted on patch set 4 V +2 CR +2 10/01/22, 12:41
-
Stefan Bürk merged patch set 5 10/01/22, 12:41