Review main Merged

75837[BUGFIX] Enforce EXT:backend as source for Source Sans fonts

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 09/22/22, 08:07

Commit message

As relative paths to the Source Sans font are used, this leads to errors
in the backend module of EXT:form as the path is resolved to
`/typo3/sysext/form/Resources/Public/Fonts/SourceSans/` there.

To relax the situation, the relative path is now enforced to always
resolve to `/typo3/sysext/backend/Resources/Public/Fonts/SourceSans/`.

In the long run, the SCSS of EXT:form needs refactoring.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Kevin Appelt +1
    • Markus Klein +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Hader +2
    • Kevin Appelt +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 78

  1. Andreas Kienast uploaded patch set 1 09/22/22, 05:57

  2. core-ci voted on patch set 1 V +1 09/22/22, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31411

  3. Markus Klein voted on patch set 1 CR +1 09/22/22, 06:06

  4. Susi Moog voted on patch set 1 V +1 CR +1 09/22/22, 06:15

  5. Kevin Appelt voted on patch set 1 V +1 CR +1 09/22/22, 06:36

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 09/22/22, 06:52

  7. Andreas Kienast merged patch set 2 09/22/22, 06:52

  8. Oliver Hader voted on patch set 2 V +2 09/22/22, 08:07