Review main Merged

75840[BUGFIX] Improve performance of "View Upgrade Documentation"

Andreas Kienast CR +2 V +2 Normal +49 −64 updated 09/22/22, 12:53

Commit message

This patch greatly improves the performance of the
"View Upgrade Documentation" module in the Install Tool.

The following optimizations are done:

* The tag filter is initialized only once now to avoid double-filtering
  documents
* Document tags are now rendered directly in Fluid, removing one
  expensive document manipulation task
* Composition of the tag list for the tag filter is sped up by a factor
  of 1.5 - 2 by using Set() to filter most duplicates
* When emptying a search, internal upgrade doc classes are removed once
  all panels are hidden
* When filtering, matching version panels are expanded with a delay of
  20ms, relaxing re-layouts and repaints in the browser

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Andreas Kienast uploaded patch set 1 09/22/22, 08:40

  2. core-ci voted on patch set 1 V +1 09/22/22, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31417

  3. Andreas Kienast updated the commit message in patch set 2 09/22/22, 09:43

  4. core-ci voted on patch set 2 V +1 09/22/22, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31419

  5. Susi Moog voted on patch set 2 V +1 09/22/22, 12:18

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 09/22/22, 12:45

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 09/22/22, 12:53

  8. Andreas Kienast merged patch set 3 09/22/22, 12:53