75843[TASK] Prevent undefined array key warnings in ext:filelist
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php5+2 −1
- typo3/sysext/core/Classes/Site/Entity/Site.php+8 −3
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+1 −1
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.php+4 −3
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+4 −3
- typo3/sysext/filelist/Classes/FileList.php+13 −8
Review log 1821
-
Oliver Hader uploaded patch set 1 09/22/22, 10:55
-
core-ci voted on patch set 1 V +1 09/22/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31423
-
Oliver Hader uploaded patch set 2 09/22/22, 11:10
-
Oliver Klee commented on patch set 2 09/22/22, 11:15
-
core-ci voted on patch set 2 V +1 09/22/22, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31424
-
Oliver Hader commented on patch set 2 09/29/22, 12:04
TranslationConfigurationProvider.php:32Reply> This works, but seems to be the wrong tool (i.e., overkill) for this purpose. A type alias would be a better match for this task: https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Thx. That what I actually would have used in TypeScript as well... a type... Will change. > Also, I propose defining this type in only one place, and then referencing it in the other places so we have a single source of truth. I don't think this is a good idea (Larry had that in once of his patches back then as well). Basically referencing to a type in another file creates another implicit dependency in PHP source code, but just for PHPStan - reorganizing code might become "interesting" then (moving around, or even deleting classes). I'd prefer to keep (these kind of) type declarations local and explicit. -
Oliver Klee commented on patch set 2 09/29/22, 12:22
TranslationConfigurationProvider.php:32ReplyAck -
Frank Nägler voted on patch set 2 V +1 CR +1 09/29/22, 13:04
-
Christian Kuhn voted on patch set 2 V +1 CR +1 09/29/22, 13:08
-
Oliver Klee commented on patch set 2 09/29/22, 15:12
TranslationConfigurationProvider.php:32ReplyThis is not resolved yet. -
Oliver Hader voted on patch set 2 CR -1 09/30/22, 22:30
-
Oliver Hader commented on patch set 2 09/30/22, 22:30
No time right prior to 12.0 -
Oliver Hader uploaded patch set 3 10/04/22, 16:30
-
core-ci voted on patch set 3 V +1 10/04/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31995
-
Oliver Hader commented on patch set 3 10/04/22, 16:53
TranslationConfigurationProvider.php:32ReplyDone -
Oliver Hader commented on patch set 3 10/04/22, 16:53
→ back-port ready at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75986 -
Oliver Klee voted on patch set 3 CR +1 10/04/22, 16:56
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/04/22, 17:25
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/04/22, 18:18
-
Oliver Hader voted on patch set 3 V +2 CR +2 10/04/22, 19:23
-
Oliver Hader merged patch set 4 10/04/22, 19:23
TranslationConfigurationProvider.php:32