Review main Merged

75843[TASK] Prevent undefined array key warnings in ext:filelist

Oliver Hader CR +2 V +2 Normal +33 −20 updated 10/04/22, 19:23

Commit message

This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1821

  1. Oliver Hader uploaded patch set 1 09/22/22, 10:55

  2. core-ci voted on patch set 1 V +1 09/22/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31423

  3. Oliver Hader uploaded patch set 2 09/22/22, 11:10

  4. Oliver Klee commented on patch set 2 09/22/22, 11:15

    TranslationConfigurationProvider.php:32

    This works, but seems to be the wrong tool (i.e., overkill) for this purpose. A type alias would be a better match for this task: https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Also, I propose defining this type in only one place, and then referencing it in the other places so we have a single source of truth.
  5. core-ci voted on patch set 2 V +1 09/22/22, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31424

  6. Oliver Hader commented on patch set 2 09/29/22, 12:04

    TranslationConfigurationProvider.php:32 Reply

    > This works, but seems to be the wrong tool (i.e., overkill) for this purpose. A type alias would be a better match for this task: https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Thx. That what I actually would have used in TypeScript as well... a type... Will change. > Also, I propose defining this type in only one place, and then referencing it in the other places so we have a single source of truth. I don't think this is a good idea (Larry had that in once of his patches back then as well). Basically referencing to a type in another file creates another implicit dependency in PHP source code, but just for PHPStan - reorganizing code might become "interesting" then (moving around, or even deleting classes). I'd prefer to keep (these kind of) type declarations local and explicit.
  7. Oliver Klee commented on patch set 2 09/29/22, 12:22

    TranslationConfigurationProvider.php:32 Reply

    Ack
  8. Frank Nägler voted on patch set 2 V +1 CR +1 09/29/22, 13:04

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 09/29/22, 13:08

  10. Oliver Klee commented on patch set 2 09/29/22, 15:12

    TranslationConfigurationProvider.php:32 Reply

    This is not resolved yet.
  11. Oliver Hader voted on patch set 2 CR -1 09/30/22, 22:30

  12. Oliver Hader commented on patch set 2 09/30/22, 22:30

    No time right prior to 12.0
  13. Oliver Hader uploaded patch set 3 10/04/22, 16:30

  14. core-ci voted on patch set 3 V +1 10/04/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31995

  15. Oliver Hader commented on patch set 3 10/04/22, 16:53

    TranslationConfigurationProvider.php:32 Reply

    Done
  16. Oliver Hader commented on patch set 3 10/04/22, 16:53

  17. Oliver Klee voted on patch set 3 CR +1 10/04/22, 16:56

  18. Christian Kuhn voted on patch set 3 V +1 CR +1 10/04/22, 17:25

  19. Stefan Bürk voted on patch set 3 V +1 CR +1 10/04/22, 18:18

  20. Oliver Hader voted on patch set 3 V +2 CR +2 10/04/22, 19:23

  21. Oliver Hader merged patch set 4 10/04/22, 19:23