Review main Merged

75845[TASK] Type hint BackendUserAuthentication->workspace to int

Christian Kuhn CR +2 V +2 Normal +121 −108 updated 09/22/22, 12:34

Commit message

Public property BackendUserAuthentication->workspace is
always an integer and should be declared as such. This
avoids a series of casts throughout the core.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 911

  1. Christian Kuhn uploaded patch set 1 09/22/22, 11:19

  2. Christian Kuhn updated the commit message in patch set 2 09/22/22, 11:28

  3. Benni Mack commented on patch set 1 09/22/22, 11:29

    Services.yaml:30

    how is this related?
  4. core-ci voted on patch set 1 V +1 09/22/22, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31426

  5. Christian Kuhn commented on patch set 2 09/22/22, 11:30

    Services.yaml:30 Reply

    I switched that class to get WorkspaceService injected. Could be separated as single patch if you insist.
  6. core-ci voted on patch set 2 V +1 09/22/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31428

  7. Benni Mack commented on patch set 2 V +1 CR +1 09/22/22, 12:15

    Services.yaml:30 Reply

    Done
  8. Stefan Bürk voted on patch set 2 V +1 CR +1 09/22/22, 12:25

  9. Andreas Kienast voted on patch set 2 CR +1 09/22/22, 12:34

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 09/22/22, 12:34

  11. Christian Kuhn merged patch set 3 09/22/22, 12:34