75845[TASK] Type hint BackendUserAuthentication->workspace to int
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 29
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −2
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+13 −5
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −2
- typo3/sysext/backend/Classes/View/BackendLayout/ContentFetcher.php+7 −1
- typo3/sysext/backend/Classes/View/PageLayoutContext.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −3
- typo3/sysext/core/Classes/Database/Query/Restriction/WorkspaceRestriction.php+1 −1
- typo3/sysext/core/Classes/Error/ErrorHandler.php+1 −3
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/redirects/Classes/Service/SlugService.php+8 −2
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+9 −6
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+1 −1
Show 9 more files
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+3 −3
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+2 −7
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+8 −2
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −1
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+8 −12
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+5 −9
- typo3/sysext/workspaces/Classes/Service/StagesService.php+1 −3
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+30 −26
- typo3/sysext/workspaces/Configuration/Services.yaml3+3 −0
Review log 911
-
Christian Kuhn uploaded patch set 1 09/22/22, 11:19
-
Christian Kuhn updated the commit message in patch set 2 09/22/22, 11:28
-
Benni Mack commented on patch set 1 09/22/22, 11:29
-
core-ci voted on patch set 1 V +1 09/22/22, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31426
-
Christian Kuhn commented on patch set 2 09/22/22, 11:30
Services.yaml:30ReplyI switched that class to get WorkspaceService injected. Could be separated as single patch if you insist. -
core-ci voted on patch set 2 V +1 09/22/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31428
-
Benni Mack commented on patch set 2 V +1 CR +1 09/22/22, 12:15
Services.yaml:30ReplyDone -
Stefan Bürk voted on patch set 2 V +1 CR +1 09/22/22, 12:25
-
Andreas Kienast voted on patch set 2 CR +1 09/22/22, 12:34
-
Christian Kuhn voted on patch set 2 V +2 CR +2 09/22/22, 12:34
-
Christian Kuhn merged patch set 3 09/22/22, 12:34
Services.yaml:30